upstream/ipython Files · IPython/core/payload.py

Fix and ...

Fix and The function in charge of actually converting cursor offset to CodeMirror line number and character number was actually crashing when the cursor was at the last character (loop until undefined, then access length of variable, which is undefined). This was hiding a bug in which when you would completer to a single completion pressing tab after as-you-type filtering, the completion would be completed twice. The logic that was supposed to detect whether or not all completions had a common prefix was actually faulty as the common prefix used to be a string but was then changed to an object. Hence the logic to check whether or not there was actually a common prefix was always true, even for empty string, leading to the deletion of the line (replace by '') in some cases.

Pablo de Oliveira - - Load All Authors

File last commit:

r12952:2f14d2ae


                r20538:ae7f6d6a

Download file

             payload.py
        
                    55 lines
            
             | 1.7 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / core / payload.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # -*- coding: utf-8 -*-

      """Payload system for IPython.

      Authors:

      * Fernando Perez

      * Brian Granger

      """

      #-----------------------------------------------------------------------------

      #       Copyright (C) 2008-2011 The IPython Development Team

      #

      #  Distributed under the terms of the BSD License.  The full license is in

      #  the file COPYING, distributed as part of this software.

      #-----------------------------------------------------------------------------

      #-----------------------------------------------------------------------------

      # Imports

      #-----------------------------------------------------------------------------

      from IPython.config.configurable import Configurable

      from IPython.utils.traitlets import List

      #-----------------------------------------------------------------------------

      # Main payload class

      #-----------------------------------------------------------------------------

      class PayloadManager(Configurable):

          _payload = List([])

          def write_payload(self, data, single=True):

              """Include or update the specified `data` payload in the PayloadManager.

              If a previous payload with the same source exists and `single` is True,

              it will be overwritten with the new one.

              """

              if not isinstance(data, dict):

                  raise TypeError('Each payload write must be a dict, got: %r' % data)

              if single and 'source' in data:

                  source = data['source']

                  for i, pl in enumerate(self._payload):

                      if 'source' in pl and pl['source'] == source:

                          self._payload[i] = data

                          return

              self._payload.append(data)

          def read_payload(self):

              return self._payload

          def clear_payload(self):

              self._payload = []

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# -- coding: utf-8 --
				"""Payload system for IPython.

				Authors:

				* Fernando Perez
				* Brian Granger
				"""

				#-----------------------------------------------------------------------------
				# Copyright (C) 2008-2011 The IPython Development Team
				#
				# Distributed under the terms of the BSD License. The full license is in
				# the file COPYING, distributed as part of this software.
				#-----------------------------------------------------------------------------

				#-----------------------------------------------------------------------------
				# Imports
				#-----------------------------------------------------------------------------

				from IPython.config.configurable import Configurable
				from IPython.utils.traitlets import List

				#-----------------------------------------------------------------------------
				# Main payload class
				#-----------------------------------------------------------------------------

				class PayloadManager(Configurable):

				_payload = List([])

				def write_payload(self, data, single=True):
				"""Include or update the specified `data` payload in the PayloadManager.

				If a previous payload with the same source exists and `single` is True,
				it will be overwritten with the new one.
				"""

				if not isinstance(data, dict):
				raise TypeError('Each payload write must be a dict, got: %r' % data)

				if single and 'source' in data:
				source = data['source']
				for i, pl in enumerate(self._payload):
				if 'source' in pl and pl['source'] == source:
				self._payload[i] = data
				return

				self._payload.append(data)

				def read_payload(self):
				return self._payload

				def clear_payload(self):
				self._payload = []