Merge pull request #4713 from takluyver/kernel-history-py2

Fix saving kernel history in Python 2

IPython/kernel/tests/test_kernel.py

@@ -1,3 +1,4 b''
+# coding: utf-8
 """test the IPython Kernel"""
 
 #-------------------------------------------------------------------------------
@@ -11,6 +12,8 b''
 # Imports
 #-------------------------------------------------------------------------------
 
+import io
+import os.path
 import sys
 
 import nose.tools as nt
@@ -18,8 +21,10 b' import nose.tools as nt'
 from IPython.testing import decorators as dec, tools as tt
 from IPython.utils import py3compat
 from IPython.utils.path import locate_profile
+from IPython.utils.tempdir import TemporaryDirectory
 
-from .utils import new_kernel, kernel, TIMEOUT, assemble_output, execute, flush_channels
+from .utils import (new_kernel, kernel, TIMEOUT, assemble_output, execute,
+                    flush_channels, wait_for_idle)
 
 #-------------------------------------------------------------------------------
 # Tests
@@ -180,6 +185,22 b' def test_eval_input():'
         nt.assert_equal(stdout, "2\n")
 
 
+def test_save_history():
+    # Saving history from the kernel with %hist -f was failing because of
+    # unicode problems on Python 2.
+    with kernel() as kc, TemporaryDirectory() as td:
+        file = os.path.join(td, 'hist.out')
+        execute(u'a=1', kc=kc)
+        wait_for_idle(kc)
+        execute(u'b=u"abcþ"', kc=kc)
+        wait_for_idle(kc)
+        _, reply = execute("%hist -f " + file, kc=kc)
+        nt.assert_equal(reply['status'], 'ok')
+        with io.open(file, encoding='utf-8') as f:
+            content = f.read()
+        nt.assert_in(u'a=1', content)
+        nt.assert_in(u'b=u"abcþ"', content)
+
 def test_help_output():
     """ipython kernel --help-all works"""
     tt.help_all_output_test('kernel')

IPython/kernel/tests/utils.py

@@ -170,5 +170,10 b' def assemble_output(iopub):'
             pass
     return stdout, stderr
 
-
-
+def wait_for_idle(kc):
+    while True:
+        msg = kc.iopub_channel.get_msg(block=True, timeout=1)
+        msg_type = msg['msg_type']
+        content = msg['content']
+        if msg_type == 'status' and content['execution_state'] == 'idle':
+            break

IPython/kernel/zmq/ipkernel.py

@@ -341,7 +341,7 b' class Kernel(Configurable):'
         
         try:
             content = parent[u'content']
-            code = content[u'code']
+            code = py3compat.cast_unicode_py2(content[u'code'])
             silent = content[u'silent']
             store_history = content.get(u'store_history', not silent)
         except:

IPython/utils/py3compat.py

@@ -83,6 +83,7 b' if sys.version_info[0] >= 3:'
     str_to_bytes = encode
     bytes_to_str = decode
     cast_bytes_py2 = no_code
+    cast_unicode_py2 = no_code
     
     string_types = (str,)
     unicode_type = str
@@ -139,6 +140,7 b' else:'
     str_to_bytes = no_code
     bytes_to_str = no_code
     cast_bytes_py2 = cast_bytes
+    cast_unicode_py2 = cast_unicode
     
     string_types = (str, unicode)
     unicode_type = unicode