##// END OF EJS Templates
Apply suggestions from code review...
M Bussonnier -
Show More
@@ -76,7 +76,7 class ProfileDir(LoggingConfigurable):
76
76
77 This is a version of os.mkdir, with the following differences:
77 This is a version of os.mkdir, with the following differences:
78
78
79 - returns wether the directory has been created or not.
79 - returns whether the directory has been created or not.
80 - ignores EEXIST, protecting against race conditions where
80 - ignores EEXIST, protecting against race conditions where
81 the dir may have been created in between the check and
81 the dir may have been created in between the check and
82 the creation
82 the creation
@@ -130,15 +130,15 class ProfileDir(LoggingConfigurable):
130 get_ipython_package_dir(), "core", "profile", "README_STARTUP"
130 get_ipython_package_dir(), "core", "profile", "README_STARTUP"
131 )
131 )
132
132
133 if not os.path.exists(src):
133 if os.path.exists(src):
134 if not os.path.exists(readme):
135 shutil.copy(src, readme)
136 else:
134 self.log.warning(
137 self.log.warning(
135 "Could not copy README_STARTUP to startup dir. Source file %s does not exist.",
138 "Could not copy README_STARTUP to startup dir. Source file %s does not exist.",
136 src,
139 src,
137 )
140 )
138
141
139 if os.path.exists(src) and not os.path.exists(readme):
140 shutil.copy(src, readme)
141
142 @observe('security_dir')
142 @observe('security_dir')
143 def check_security_dir(self, change=None):
143 def check_security_dir(self, change=None):
144 self._mkdir(self.security_dir, 0o40700)
144 self._mkdir(self.security_dir, 0o40700)
General Comments 0
You need to be logged in to leave comments. Login now