##// END OF EJS Templates
Merge pull request #10041 from ivanov/remove-test_pr...
Thomas Kluyver -
r22997:18c42b10 merge
parent child Browse files
Show More
@@ -1,45 +1,45 b''
1 ## Opening an Issue
1 ## Opening an Issue
2
2
3 When opening a new Issue, please take the following steps:
3 When opening a new Issue, please take the following steps:
4
4
5 1. Search GitHub and/or Google for your issue to avoid duplicate reports.
5 1. Search GitHub and/or Google for your issue to avoid duplicate reports.
6 Keyword searches for your error messages are most helpful.
6 Keyword searches for your error messages are most helpful.
7 2. If possible, try updating to master and reproducing your issue,
7 2. If possible, try updating to master and reproducing your issue,
8 because we may have already fixed it.
8 because we may have already fixed it.
9 3. Try to include a minimal reproducible test case
9 3. Try to include a minimal reproducible test case
10 4. Include relevant system information. Start with the output of:
10 4. Include relevant system information. Start with the output of:
11
11
12 python -c "import IPython; print(IPython.sys_info())"
12 python -c "import IPython; print(IPython.sys_info())"
13
13
14 And include any relevant package versions, depending on the issue,
14 And include any relevant package versions, depending on the issue,
15 such as matplotlib, numpy, Qt, Qt bindings (PyQt/PySide), tornado, web browser, etc.
15 such as matplotlib, numpy, Qt, Qt bindings (PyQt/PySide), tornado, web browser, etc.
16
16
17 ## Pull Requests
17 ## Pull Requests
18
18
19 Some guidelines on contributing to IPython:
19 Some guidelines on contributing to IPython:
20
20
21 * All work is submitted via Pull Requests.
21 * All work is submitted via Pull Requests.
22 * Pull Requests can be submitted as soon as there is code worth discussing.
22 * Pull Requests can be submitted as soon as there is code worth discussing.
23 Pull Requests track the branch, so you can continue to work after the PR is submitted.
23 Pull Requests track the branch, so you can continue to work after the PR is submitted.
24 Review and discussion can begin well before the work is complete,
24 Review and discussion can begin well before the work is complete,
25 and the more discussion the better.
25 and the more discussion the better.
26 The worst case is that the PR is closed.
26 The worst case is that the PR is closed.
27 * Pull Requests should generally be made against master
27 * Pull Requests should generally be made against master
28 * Pull Requests should be tested, if feasible:
28 * Pull Requests should be tested, if feasible:
29 - bugfixes should include regression tests
29 - bugfixes should include regression tests
30 - new behavior should at least get minimal exercise
30 - new behavior should at least get minimal exercise
31 * New features and backwards-incompatible changes should be documented by adding
31 * New features and backwards-incompatible changes should be documented by adding
32 a new file to the [pr](docs/source/whatsnew/pr) directory, see [the README.md
32 a new file to the [pr](docs/source/whatsnew/pr) directory, see [the README.md
33 there](docs/source/whatsnew/pr/README.md) for details.
33 there](docs/source/whatsnew/pr/README.md) for details.
34 * Don't make 'cleanup' pull requests just to change code style.
34 * Don't make 'cleanup' pull requests just to change code style.
35 We don't follow any style guide strictly, and we consider formatting changes
35 We don't follow any style guide strictly, and we consider formatting changes
36 unnecessary noise.
36 unnecessary noise.
37 If you're making functional changes, you can clean up the specific pieces of
37 If you're making functional changes, you can clean up the specific pieces of
38 code you're working on.
38 code you're working on.
39
39
40 [Travis](http://travis-ci.org/#!/ipython/ipython) does a pretty good job testing IPython and Pull Requests,
40 [Travis](http://travis-ci.org/#!/ipython/ipython) does a pretty good job testing
41 but it may make sense to manually perform tests (possibly with our `test_pr` script),
41 IPython and Pull Requests, but it may make sense to manually perform tests,
42 particularly for PRs that affect `IPython.parallel` or Windows.
42 particularly for PRs that affect `IPython.parallel` or Windows.
43
43
44 For more detailed information, see our [GitHub Workflow](https://github.com/ipython/ipython/wiki/Dev:-GitHub-workflow).
44 For more detailed information, see our [GitHub Workflow](https://github.com/ipython/ipython/wiki/Dev:-GitHub-workflow).
45
45
1 NO CONTENT: file was removed
NO CONTENT: file was removed
1 NO CONTENT: file was removed
NO CONTENT: file was removed
General Comments 0
You need to be logged in to leave comments. Login now