Uppercase constant keycode in utils.js

IPython/frontend/html/notebook/static/js/codecell.js

@@ -67,13 +67,13 b' var IPython = (function (IPython) {'
         var that = this;
         // whatever key is pressed, first, cancel the tooltip request before
         // they are sent, and remove tooltip if any, except for tab again
-        if(event.type === 'keydown' && event.which != key.tab ) {
+        if (event.type === 'keydown' && event.which != key.TAB ) {
             IPython.tooltip.remove_and_cancel_tooltip();
         };
 
         var cur = editor.getCursor();
 
-        if (event.keyCode === key.enter && (event.shiftKey || event.ctrlKey)) {
+        if (event.keyCode === key.ENTER && (event.shiftKey || event.ctrlKey)) {
             // Always ignore shift-enter in CodeMirror as we handle it.
             return true;
         } else if (event.which === 40 && event.type === 'keypress' && IPython.tooltip.time_before_tooltip >= 0) {
@@ -81,7 +81,7 b' var IPython = (function (IPython) {'
             // browser and keyboard layout !
             // Pressing '(' , request tooltip, don't forget to reappend it
             IPython.tooltip.pending(that);
-        } else if (event.which === key.upArrow) {
+        } else if (event.which === key.UPARROW) {
             // If we are not at the top, let CM handle the up arrow and
             // prevent the global keydown handler from handling it.
             if (!that.at_top()) {
@@ -90,7 +90,7 b' var IPython = (function (IPython) {'
             } else {
                 return true; 
             };
-        } else if (event.which === key.downArrow) {
+        } else if (event.which === key.DOWNARROW) {
             // If we are not at the bottom, let CM handle the down arrow and
             // prevent the global keydown handler from handling it.
             if (!that.at_bottom()) {
@@ -99,7 +99,7 b' var IPython = (function (IPython) {'
             } else {
                 return true; 
             };
-        } else if (event.keyCode === key.tab && event.type == 'keydown') {
+        } else if (event.keyCode === key.TAB && event.type == 'keydown') {
             // Tab completion.
             //Do not trim here because of tooltip
             var pre_cursor = editor.getRange({line:cur.line,ch:0},cur);
@@ -118,7 +118,7 b' var IPython = (function (IPython) {'
                 this.completer.startCompletion();
                 return true;
             };
-        } else if (event.keyCode === key.backspace && event.type == 'keydown') {
+        } else if (event.keyCode === key.BACKSPACE && event.type == 'keydown') {
             // If backspace and the line ends with 4 spaces, remove them.
             var line = editor.getLine(cur.line);
             var ending = line.slice(-4);

IPython/frontend/html/notebook/static/js/completer.js

@@ -227,19 +227,19 b' var IPython = (function (IPython) {'
         var code = event.keyCode;
         var that = this;
         // Enter
-        if (code == key.enter) {
+        if (code == key.ENTER) {
             CodeMirror.e_stop(event);
             this.pick();
         }
         // Escape or backspace
-        else if (code == key.esc) {
+        else if (code == key.ESC) {
             CodeMirror.e_stop(event);
             this.close();
             this.editor.focus();
-        } else if (code == key.space || code == key.backspace) {
+        } else if (code == key.SPACE || code == key.BACKSPACE) {
             this.close();
             this.editor.focus();
-        } else if (code == key.tab) {
+        } else if (code == key.TAB) {
             //all the fastforwarding operation,
             //Check that shared start is not null which can append with prefixed completion
             // like %pylab , pylab have no shred start, and ff will result in py<tab><tab>
@@ -255,11 +255,11 b' var IPython = (function (IPython) {'
             setTimeout(function () {
                 that.carry_on_completion();
             }, 50);
-        } else if (code == key.upArrow || code == key.downArrow) {
+        } else if (code == key.UPARROW || code == key.DOWNARROW) {
             // need to do that to be able to move the arrow
             // when on the first or last line ofo a code cell
             event.stopPropagation();
-        } else if (code != key.upArrow && code != key.downArrow) {
+        } else if (code != key.UPARROW && code != key.DOWNARROW) {
             this.close();
             this.editor.focus();
             //we give focus to the editor immediately and call sell in 50 ms

IPython/frontend/html/notebook/static/js/notebook.js

@@ -84,27 +84,27 b' var IPython = (function (IPython) {'
                 that.save_notebook();
                 event.preventDefault();
                 return false;
-            } else if (event.which === key.esc) {
+            } else if (event.which === key.ESC) {
                 // Intercept escape at highest level to avoid closing 
                 // websocket connection with firefox
                 event.preventDefault();
             }
-            if (event.which === key.upArrow && !event.shiftKey) {
+            if (event.which === key.UPARROW && !event.shiftKey) {
                 var cell = that.get_selected_cell();
                 if (cell.at_top()) {
                     event.preventDefault();
                     that.select_prev();
                 };
-            } else if (event.which === key.downArrow && !event.shiftKey) {
+            } else if (event.which === key.DOWNARROW && !event.shiftKey) {
                 var cell = that.get_selected_cell();
                 if (cell.at_bottom()) {
                     event.preventDefault();
                     that.select_next();
                 };
-            } else if (event.which === key.enter && event.shiftKey) {
+            } else if (event.which === key.ENTER && event.shiftKey) {
                 that.execute_selected_cell();
                 return false;
-            } else if (event.which === key.enter && event.ctrlKey) {
+            } else if (event.which === key.ENTER && event.ctrlKey) {
                 that.execute_selected_cell({terminal:true});
                 return false;
             } else if (event.which === 77 && event.ctrlKey && that.control_key_active == false) {

IPython/frontend/html/notebook/static/js/utils.js

@@ -93,22 +93,28 b' IPython.utils = (function (IPython) {'
 
     // some keycodes that seem to be platform/browser independant
     var keycodes ={
-                backspace:  8,
-                tab      :  9,
-                enter    : 13,
-                shift    : 16,
-                ctrl     : 17,
-                control  : 17,
-                esc      : 27,
-                space    : 32,
-                pgUp     : 33,
-                pgDown   : 34,
-                leftArrow: 37,
-                left     : 37,
-                upArrow  : 38,
-                rightArrow:39,
-                right    : 39,
-                downArrow: 40,
+                BACKSPACE:  8,
+                TAB      :  9,
+                ENTER    : 13,
+                SHIFT    : 16,
+                CTRL     : 17,
+                CONTROL  : 17,
+                ESC      : 27,
+                SPACE    : 32,
+                PGUP     : 33,
+                PGDOWN   : 34,
+                LEFT_ARROW: 37,
+                LEFTARROW: 37,
+                LEFT     : 37,
+                UP_ARROW : 38,
+                UPARROW  : 38,
+                UP       : 38,
+                RIGHT_ARROW:39,
+                RIGHTARROW:39,
+                RIGHT    : 39,
+                DOWN_ARROW: 40,
+                DOWNARROW: 40,
+                DOWN     : 40,
     };
 
     return {