##// END OF EJS Templates
upstream » ipython
RSS

Clone from https://github.com/ipython/ipython.git

don't warn if the iframe isn't the only thing in the data
Michael Penkov -
Show More
Show file before | Show file after | Hide comments
@@ -667,7 +667,7 b' class Pretty(TextDisplayObject):'
667 class HTML(TextDisplayObject):
667 class HTML(TextDisplayObject):
668
668
669 def __init__(self, data=None, url=None, filename=None, metadata=None):
669 def __init__(self, data=None, url=None, filename=None, metadata=None):
670 if data and "<iframe " in data and "</iframe>" in data:
670 if data and data.startswith("<iframe ") and data.endswith("</iframe>"):
671 warnings.warn("Consider using IPython.display.IFrame instead")
671 warnings.warn("Consider using IPython.display.IFrame instead")
672 super(HTML, self).__init__(data=data, url=url, filename=filename, metadata=metadata)
672 super(HTML, self).__init__(data=data, url=url, filename=filename, metadata=metadata)
673
673
Show file before | Show file after | Hide comments
@@ -200,6 +200,9 b' def test_encourage_iframe_over_html(m_warn):'
200 display.HTML('<br />')
200 display.HTML('<br />')
201 m_warn.assert_not_called()
201 m_warn.assert_not_called()
202
202
203 display.HTML('<html><p>Lots of content here</p><iframe src="http://a.com"></iframe>')
204 m_warn.assert_not_called()
205
203 display.HTML('<iframe src="http://a.com"></iframe>')
206 display.HTML('<iframe src="http://a.com"></iframe>')
204 m_warn.assert_called_with('Consider using IPython.display.IFrame instead')
207 m_warn.assert_called_with('Consider using IPython.display.IFrame instead')
205
208
General Comments 0
You need to be logged in to leave comments. Login now