##// END OF EJS Templates
Address some more review comments...
Jonathan Frederic -
Show More
@@ -27,7 +27,7 b' casper.notebook_test(function () {'
27
27
28 index = this.append_cell(
28 index = this.append_cell(
29 'from IPython.html.widgets import Widget\n' +
29 'from IPython.html.widgets import Widget\n' +
30 'widget = Widget.widgets.values()[0]\n' +
30 'widget = list(Widget.widgets.values())[0]\n' +
31 'print(widget.model_id)');
31 'print(widget.model_id)');
32 this.execute_cell_then(index, function(index) {
32 this.execute_cell_then(index, function(index) {
33 var output = this.get_output_cell(index).text.trim();
33 var output = this.get_output_cell(index).text.trim();
@@ -101,8 +101,7 b' class Widget(LoggingConfigurable):'
101 """Static method, called when a widget is constructed."""
101 """Static method, called when a widget is constructed."""
102 target_name = msg['content']['data']['target_name']
102 target_name = msg['content']['data']['target_name']
103 widget_class = import_item(target_name)
103 widget_class = import_item(target_name)
104 widget = widget_class(open_comm=False)
104 widget = widget_class(comm=comm)
105 widget.comm = comm
106
105
107
106
108 #-------------------------------------------------------------------------
107 #-------------------------------------------------------------------------
@@ -141,8 +140,7 b' class Widget(LoggingConfigurable):'
141 super(Widget, self).__init__(**kwargs)
140 super(Widget, self).__init__(**kwargs)
142
141
143 Widget._call_widget_constructed(self)
142 Widget._call_widget_constructed(self)
144 if open_comm:
143 self.open()
145 self.open()
146
144
147 def __del__(self):
145 def __del__(self):
148 """Object disposal"""
146 """Object disposal"""
General Comments 0
You need to be logged in to leave comments. Login now