Download '.py' fixed, deleted debugging output

IPython/html/notebook/handlers.py

@@ -1,98 +1,94 b''
 """Tornado handlers for the live notebook view.
 
 Authors:
 
 * Brian Granger
 """
 
 #-----------------------------------------------------------------------------
 #  Copyright (C) 2011  The IPython Development Team
 #
 #  Distributed under the terms of the BSD License.  The full license is in
 #  the file COPYING, distributed as part of this software.
 #-----------------------------------------------------------------------------
 
 #-----------------------------------------------------------------------------
 # Imports
 #-----------------------------------------------------------------------------
 
 import os
 from tornado import web
 HTTPError = web.HTTPError
 
 from ..base.handlers import IPythonHandler
 from ..utils import url_path_join
-from urllib import quote
 
 #-----------------------------------------------------------------------------
 # Handlers
 #-----------------------------------------------------------------------------
 
 
 class NewPathHandler(IPythonHandler):
     
     @web.authenticated
     def get(self, notebook_path):
         notebook_name = self.notebook_manager.new_notebook(notebook_path)
         self.redirect(url_path_join(self.base_project_url,"notebooks", notebook_path, notebook_name))
         
 
 class NewHandler(IPythonHandler):
 
     @web.authenticated
     def get(self):
         notebook_name = self.notebook_manager.new_notebook()
         self.redirect(url_path_join(self.base_project_url, "notebooks", notebook_name))
 
 
 class NamedNotebookHandler(IPythonHandler):
 
     @web.authenticated
     def get(self, notebook_path):
         nbm = self.notebook_manager
         name, path = nbm.named_notebook_path(notebook_path)
-        if name != None:
-            name = quote(name)
-        self.log.info(name)
         if path == None:
             project = self.project + '/' + name
         else:
             project = self.project + '/' + path +'/'+ name
         #if not nbm.notebook_exists(notebook_path):
          #   raise web.HTTPError(404, u'Notebook does not exist: %s' % notebook_path)       
         self.write(self.render_template('notebook.html',
             project=project,
             notebook_path=path,
             notebook_name=name,
             kill_kernel=False,
             mathjax_url=self.mathjax_url,
             )
         )
 
 
 class NotebookCopyHandler(IPythonHandler):
 
     @web.authenticated
     def get(self, notebook_path=None):
         nbm = self.notebook_manager
         name, path = nbm.named_notebook_path(notebook_path)
         notebook_name = self.notebook_manager.copy_notebook(name, path)
         if path==None:
             self.redirect(url_path_join(self.base_project_url, "notebooks", notebook_name))
         else:
             self.redirect(url_path_join(self.base_project_url, "notebooks", path, notebook_name))
 
 
 #-----------------------------------------------------------------------------
 # URL to handler mappings
 #-----------------------------------------------------------------------------
 
 
 _notebook_path_regex = r"(?P<notebook_path>.+)"
 
 default_handlers = [
     (r"/notebooks/%s/new" % _notebook_path_regex, NewPathHandler),
     (r"/notebooks/new", NewHandler),
     (r"/notebooks/%s/copy" % _notebook_path_regex, NotebookCopyHandler),
     (r"/notebooks/%s" % _notebook_path_regex, NamedNotebookHandler)
 ]

IPython/html/services/notebooks/handlers.py

@@ -1,199 +1,199 b''
 """Tornado handlers for the notebooks web service.
 
 Authors:
 
 * Brian Granger
 """
 
 #-----------------------------------------------------------------------------
 #  Copyright (C) 2008-2011  The IPython Development Team
 #
 #  Distributed under the terms of the BSD License.  The full license is in
 #  the file COPYING, distributed as part of this software.
 #-----------------------------------------------------------------------------
 
 #-----------------------------------------------------------------------------
 # Imports
 #-----------------------------------------------------------------------------
 
 from tornado import web
 import ast
 
 from zmq.utils import jsonapi
 
 from IPython.utils.jsonutil import date_default
 
 from ...base.handlers import IPythonHandler
 
 #-----------------------------------------------------------------------------
 # Notebook web service handlers
 #-----------------------------------------------------------------------------
 
 
 class NotebookRootHandler(IPythonHandler):
 
     @web.authenticated
     def get(self):
         nbm = self.notebook_manager
         km = self.kernel_manager
         notebooks = nbm.list_notebooks("")
         self.finish(jsonapi.dumps(notebooks))
 
     @web.authenticated
     def post(self):
         nbm = self.notebook_manager
         notebook_name = nbm.new_notebook()
         model = nbm.notebook_model(notebook_name)
         self.set_header('Location', '{0}api/notebooks/{1}'.format(self.base_project_url, notebook_name))
         self.finish(jsonapi.dumps(model))
         
         
 class NotebookRootRedirect(IPythonHandler):
 
     @authenticate_unless_readonly
     def get(self):
         self.redirect("/api/notebooks")
 
 
 class NotebookHandler(IPythonHandler):
 
     SUPPORTED_METHODS = ('GET', 'PUT', 'PATCH', 'DELETE')
 
     @web.authenticated
     def get(self, notebook_path):
         nbm = self.notebook_manager
         name, path = nbm.named_notebook_path(notebook_path)
         
         if name == None:
             notebooks = nbm.list_notebooks(path)
             self.finish(jsonapi.dumps(notebooks))
         else:
             format = self.get_argument('format', default='json')
             model = nbm.notebook_model(name,path)
-            data, name = nbm.get_notebook(model, format)
+            last_mod, representation, name = nbm.get_notebook(name, path, format)
 
             if format == u'json':
                 self.set_header('Content-Type', 'application/json')
                 self.set_header('Content-Disposition','attachment; filename="%s.ipynb"' % name)
             elif format == u'py':
                 self.set_header('Content-Type', 'application/x-python')
                 self.set_header('Content-Disposition','attachment; filename="%s.py"' % name)
             #self.set_header('Last-Modified', last_mod)
             self.finish(jsonapi.dumps(model))
 
     @web.authenticated
     def patch(self, notebook_path):
         nbm = self.notebook_manager
         notebook_name, notebook_path = nbm.named_notebook_path(notebook_path)
         data = jsonapi.loads(self.request.body)
         model = nbm.change_notebook(data, notebook_name, notebook_path)
         self.finish(jsonapi.dumps(model))
 
     @web.authenticated
     def put(self, notebook_path):
         nbm = self.notebook_manager
         notebook_name, notebook_path = nbm.named_notebook_path(notebook_path)        
         if notebook_name == None:
             body = self.request.body.strip()
             format = self.get_argument('format', default='json')
             name = self.get_argument('name', default=None)
             if body:
                 notebook_name = nbm.save_new_notebook(body, notebook_path=notebook_path, name=name, format=format)
             else:
                 notebook_name = nbm.new_notebook(notebook_path=notebook_path)
             if notebook_path==None:
                 self.set_header('Location', nbm.notebook_dir + '/'+ notebook_name)
             else:
                 self.set_header('Location', nbm.notebook_dir + '/'+ notebook_path + '/' + notebook_name)
             model = nbm.notebook_model(notebook_name, notebook_path)
             self.finish(jsonapi.dumps(model))
         else:            
             format = self.get_argument('format', default='json')
             name = self.get_argument('name', default=None)
             nbm.save_notebook(self.request.body, notebook_path=notebook_path, name=name, format=format)
             model = nbm.notebook_model(notebook_name, notebook_path)
             self.set_status(204)
             self.finish(jsonapi.dumps(model))
 
     @web.authenticated
     def delete(self, notebook_path):
         nbm = self.notebook_manager
         name, path = nbm.named_notebook_path(notebook_path)
         nbm.delete_notebook(name, path)
         self.set_status(204)
         self.finish()
 
 
 class NotebookCheckpointsHandler(IPythonHandler):
     
     SUPPORTED_METHODS = ('GET', 'POST')
     
     @web.authenticated
     def get(self, notebook_path):
         """get lists checkpoints for a notebook"""
         nbm = self.notebook_manager
         name, path = nbm.named_notebook_path(notebook_path)
         checkpoints = nbm.list_checkpoints(name, path)
         data = jsonapi.dumps(checkpoints, default=date_default)
         self.finish(data)
     
     @web.authenticated
     def post(self, notebook_path):
         """post creates a new checkpoint"""
         nbm = self.notebook_manager
         name, path = nbm.named_notebook_path(notebook_path)
         checkpoint = nbm.create_checkpoint(name, path)
         data = jsonapi.dumps(checkpoint, default=date_default)
         if path == None:
             self.set_header('Location', '{0}notebooks/{1}/checkpoints/{2}'.format(
                 self.base_project_url, name, checkpoint['checkpoint_id']
                 ))
         else:
             self.set_header('Location', '{0}notebooks/{1}/{2}/checkpoints/{3}'.format(
                 self.base_project_url, path, name, checkpoint['checkpoint_id']
                 ))
         self.finish(data)
 
 
 class ModifyNotebookCheckpointsHandler(IPythonHandler):
     
     SUPPORTED_METHODS = ('POST', 'DELETE')
     
     @web.authenticated
     def post(self, notebook_path, checkpoint_id):
         """post restores a notebook from a checkpoint"""
         nbm = self.notebook_manager
         name, path = nbm.named_notebook_path(notebook_path)
         nbm.restore_checkpoint(name, checkpoint_id, path)
         self.set_status(204)
         self.finish()
     
     @web.authenticated
     def delete(self, notebook_path, checkpoint_id):
         """delete clears a checkpoint for a given notebook"""
         nbm = self.notebook_manager
         name, path = nbm.named_notebook_path(notebook_path)
         nbm.delete_checkpoint(name, checkpoint_id, path)
         self.set_status(204)
         self.finish()
         
 #-----------------------------------------------------------------------------
 # URL to handler mappings
 #-----------------------------------------------------------------------------
 
 
 _notebook_path_regex = r"(?P<notebook_path>.+)"
 _checkpoint_id_regex = r"(?P<checkpoint_id>[\w-]+)"
 
 default_handlers = [
     (r"api/notebooks/%s/checkpoints" % _notebook_path_regex, NotebookCheckpointsHandler),
     (r"api/notebooks/%s/checkpoints/%s" % (_notebook_path_regex, _checkpoint_id_regex),
         ModifyNotebookCheckpointsHandler),
     (r"api/notebooks/%s" % _notebook_path_regex, NotebookHandler),
     (r"api/notebooks/", NotebookRootRedirect),
     (r"api/notebooks", NotebookRootHandler),
 ]
 
 
 
 

IPython/html/services/notebooks/nbmanager.py

@@ -1,240 +1,241 b''
 """A base class notebook manager.
 
 Authors:
 
 * Brian Granger
 """
 
 #-----------------------------------------------------------------------------
 #  Copyright (C) 2011  The IPython Development Team
 #
 #  Distributed under the terms of the BSD License.  The full license is in
 #  the file COPYING, distributed as part of this software.
 #-----------------------------------------------------------------------------
 
 #-----------------------------------------------------------------------------
 # Imports
 #-----------------------------------------------------------------------------
 
 import os
 import uuid
 
 from tornado import web
 
 from IPython.config.configurable import LoggingConfigurable
 from IPython.nbformat import current
 from IPython.utils.traitlets import List, Dict, Unicode, TraitError
 
 #-----------------------------------------------------------------------------
 # Classes
 #-----------------------------------------------------------------------------
 
 class NotebookManager(LoggingConfigurable):
 
     # Todo:
     # The notebook_dir attribute is used to mean a couple of different things:
     # 1. Where the notebooks are stored if FileNotebookManager is used.
     # 2. The cwd of the kernel for a project.
     # Right now we use this attribute in a number of different places and
     # we are going to have to disentangle all of this.
     notebook_dir = Unicode(os.getcwdu(), config=True, help="""
             The directory to use for notebooks.
             """)
             
     def named_notebook_path(self, notebook_path):
         
         l = len(notebook_path)
         names = notebook_path.split('/')
         if len(names) > 1:     
             name = names[len(names)-1]
             if name[(len(name)-6):(len(name))] == ".ipynb":
                 name = name
                 path = notebook_path[0:l-len(name)-1]+'/'
             else:
                 name = None
                 path = notebook_path+'/'
         else:
             name = names[0]
             if name[(len(name)-6):(len(name))] == ".ipynb":
                 name = name
                 path = None
             else:
                 name = None
                 path = notebook_path+'/'
         return name, path
              
     def _notebook_dir_changed(self, new):
         """do a bit of validation of the notebook dir"""
         if not os.path.isabs(new):
             # If we receive a non-absolute path, make it absolute.
             abs_new = os.path.abspath(new)
             #self.notebook_dir = os.path.dirname(abs_new)
             return
         if os.path.exists(new) and not os.path.isdir(new):
             raise TraitError("notebook dir %r is not a directory" % new)
         if not os.path.exists(new):
             self.log.info("Creating notebook dir %s", new)
             try:
                 os.mkdir(new)
             except:
                 raise TraitError("Couldn't create notebook dir %r" % new)
                 
     allowed_formats = List([u'json',u'py'])
 
 
     def load_notebook_names(self, path):
         """Load the notebook names into memory.
 
         This should be called once immediately after the notebook manager
         is created to load the existing notebooks into the mapping in
         memory.
         """
         self.list_notebooks(path)
 
     def list_notebooks(self):
         """List all notebooks.
 
         This returns a list of dicts, each of the form::
 
             dict(notebook_id=notebook,name=name)
 
         This list of dicts should be sorted by name::
 
             data = sorted(data, key=lambda item: item['name'])
         """
         raise NotImplementedError('must be implemented in a subclass')
 
 
     def notebook_exists(self, notebook_name):
         """Does a notebook exist?"""
         return notebook_name in self.mapping
 
     def notebook_model(self, notebook_name, notebook_path=None):
         """ Creates the standard notebook model """
         last_modified, content = self.read_notebook_object(notebook_name, notebook_path)
         model = {"notebook_name": notebook_name, 
                     "notebook_path": notebook_path,
                     "content": content}
         return model
 
-    def get_notebook(self, body, format=u'json'):
+    def get_notebook(self, notebook_name, notebook_path=None, format=u'json'):
         """Get the representation of a notebook in format by notebook_name."""
         format = unicode(format)
         if format not in self.allowed_formats:
             raise web.HTTPError(415, u'Invalid notebook format: %s' % format)
         kwargs = {}
+        last_mod, nb = self.read_notebook_object(notebook_name, notebook_path)
         if format == 'json':
             # don't split lines for sending over the wire, because it
             # should match the Python in-memory format.
             kwargs['split_lines'] = False
-        representation = current.writes(body, format, **kwargs)
-        name = body['content']['metadata']['name']
-        return representation, name
+        representation = current.writes(nb, format, **kwargs)
+        name = nb.metadata.get('name', 'notebook')
+        return last_mod, representation, name
 
     def read_notebook_object(self, notebook_name, notebook_path):
         """Get the object representation of a notebook by notebook_id."""
         raise NotImplementedError('must be implemented in a subclass')
 
     def save_new_notebook(self, data, notebook_path = None, name=None, format=u'json'):
         """Save a new notebook and return its notebook_id.
 
         If a name is passed in, it overrides any values in the notebook data
         and the value in the data is updated to use that value.
         """
         if format not in self.allowed_formats:
             raise web.HTTPError(415, u'Invalid notebook format: %s' % format)
 
         try:
             nb = current.reads(data.decode('utf-8'), format)
         except:
             raise web.HTTPError(400, u'Invalid JSON data')
 
         if name is None:
            try:
                name = nb.metadata.name
            except AttributeError:
                raise web.HTTPError(400, u'Missing notebook name')
         nb.metadata.name = name
 
         notebook_name = self.write_notebook_object(nb, notebook_path=notebook_path)
         return notebook_name
 
     def save_notebook(self, data, notebook_path=None, name=None, new_name=None, format=u'json'):
         """Save an existing notebook by notebook_name."""
         if format not in self.allowed_formats:
             raise web.HTTPError(415, u'Invalid notebook format: %s' % format)
 
         try:
             nb = current.reads(data.decode('utf-8'), format)
         except:
             raise web.HTTPError(400, u'Invalid JSON data')
 
         if name is not None:
             nb.metadata.name = name
         self.write_notebook_object(nb, name, notebook_path, new_name)
 
     def write_notebook_object(self, nb, notebook_name=None, notebook_path=None, new_name=None):
         """Write a notebook object and return its notebook_name.
 
         If notebook_name is None, this method should create a new notebook_name.
         If notebook_name is not None, this method should check to make sure it
         exists and is valid.
         """
         raise NotImplementedError('must be implemented in a subclass')
 
     def delete_notebook(self, notebook_name, notebook_path):
         """Delete notebook by notebook_id."""
         raise NotImplementedError('must be implemented in a subclass')
 
     def increment_filename(self, name):
         """Increment a filename to make it unique.
 
         This exists for notebook stores that must have unique names. When a notebook
         is created or copied this method constructs a unique filename, typically
         by appending an integer to the name.
         """
         return name
 
     def new_notebook(self, notebook_path=None):
         """Create a new notebook and return its notebook_id."""
         name = self.increment_filename('Untitled', notebook_path)
         metadata = current.new_metadata(name=name)
         nb = current.new_notebook(metadata=metadata)
         notebook_name = self.write_notebook_object(nb, notebook_path=notebook_path)
         return notebook_name
 
     def copy_notebook(self, name, path):
         """Copy an existing notebook and return its notebook_id."""
         last_mod, nb = self.read_notebook_object(name, path)
         name = nb.metadata.name + '-Copy'
         name = self.increment_filename(name, path)
         nb.metadata.name = name
         notebook_name = self.write_notebook_object(nb, notebook_path = path)
         return notebook_name  
     
     # Checkpoint-related
     
     def create_checkpoint(self, notebook_name, notebook_path=None):
         """Create a checkpoint of the current state of a notebook
         
         Returns a checkpoint_id for the new checkpoint.
         """
         raise NotImplementedError("must be implemented in a subclass")
     
     def list_checkpoints(self, notebook_name, notebook_path=None):
         """Return a list of checkpoints for a given notebook"""
         return []
     
     def restore_checkpoint(self, notebook_name, checkpoint_id, notebook_path=None):
         """Restore a notebook from one of its checkpoints"""
         raise NotImplementedError("must be implemented in a subclass")
 
     def delete_checkpoint(self, notebook_name, checkpoint_id, notebook_path=None):
         """delete a checkpoint for a notebook"""
         raise NotImplementedError("must be implemented in a subclass")
     
     def log_info(self):
         self.log.info(self.info_string())
     
     def info_string(self):
         return "Serving notebooks"