##// END OF EJS Templates
deleting a comm now unregisters the comm. unrehistering the comm does not close it anymore
sylvain.corlay -
Show More
@@ -70,6 +70,7 b' class Comm(LoggingConfigurable):'
70 def __del__(self):
70 def __del__(self):
71 """trigger close on gc"""
71 """trigger close on gc"""
72 self.close()
72 self.close()
73 get_ipython().comm_manager.unregister_comm(self)
73
74
74 # publishing messages
75 # publishing messages
75
76
@@ -76,7 +76,6 b' class CommManager(LoggingConfigurable):'
76 """Unregister a comm, and close its counterpart"""
76 """Unregister a comm, and close its counterpart"""
77 # unlike get_comm, this should raise a KeyError
77 # unlike get_comm, this should raise a KeyError
78 comm = self.comms.pop(comm_id)
78 comm = self.comms.pop(comm_id)
79 comm.close()
80
79
81 def get_comm(self, comm_id):
80 def get_comm(self, comm_id):
82 """Get a comm with a particular id
81 """Get a comm with a particular id
General Comments 0
You need to be logged in to leave comments. Login now