##// END OF EJS Templates
upstream » ipython
RSS

Clone from https://github.com/ipython/ipython.git

Fix bug in all children containing views
Jonathan Frederic -
Show More
Show file before | Show file after | Hide comments
@@ -22,9 +22,9 b' define(["notebook/js/widgets/widget"], function(widget_manager) {'
22 this.$el
22 this.$el
23 .addClass('widget-container');
23 .addClass('widget-container');
24 this.children={};
24 this.children={};
25 this.update_children([], this.model.get('children'));
25 this.update_children([], this.model.get('_children'));
26 this.model.on('change:children', function(model, value, options) {
26 this.model.on('change:_children', function(model, value, options) {
27 this.update_children(model.previous('children'), value);
27 this.update_children(model.previous('_children'), value);
28 }, this);
28 }, this);
29 this.update()
29 this.update()
30 },
30 },
@@ -65,9 +65,9 b' define(["notebook/js/widgets/widget"], function(widget_manager) {'
65 // Called when view is rendered.
65 // Called when view is rendered.
66 var that = this;
66 var that = this;
67 this.children={};
67 this.children={};
68 this.update_children([], this.model.get('children'));
68 this.update_children([], this.model.get('_children'));
69 this.model.on('change:children', function(model, value, options) {
69 this.model.on('change:_children', function(model, value, options) {
70 this.update_children(model.previous('children'), value);
70 this.update_children(model.previous('_children'), value);
71 }, this);
71 }, this);
72
72
73 this.$el
73 this.$el
Show file before | Show file after | Hide comments
@@ -25,9 +25,9 b' define(["notebook/js/widgets/widget"], function(widget_manager){'
25 .addClass('accordion');
25 .addClass('accordion');
26 this.containers = [];
26 this.containers = [];
27 this.model_containers = {};
27 this.model_containers = {};
28 this.update_children([], this.model.get('children'));
28 this.update_children([], this.model.get('_children'));
29 this.model.on('change:children', function(model, value, options) {
29 this.model.on('change:_children', function(model, value, options) {
30 this.update_children(model.previous('children'), value);
30 this.update_children(model.previous('_children'), value);
31 }, this);
31 }, this);
32 },
32 },
33
33
@@ -151,9 +151,9 b' define(["notebook/js/widgets/widget"], function(widget_manager){'
151 .addClass('tab-content')
151 .addClass('tab-content')
152 .appendTo(this.$el);
152 .appendTo(this.$el);
153 this.containers = [];
153 this.containers = [];
154 this.update_children([], this.model.get('children'));
154 this.update_children([], this.model.get('_children'));
155 this.model.on('change:children', function(model, value, options) {
155 this.model.on('change:_children', function(model, value, options) {
156 this.update_children(model.previous('children'), value);
156 this.update_children(model.previous('_children'), value);
157 }, this);
157 }, this);
158 },
158 },
159
159
General Comments 0
You need to be logged in to leave comments. Login now