##// END OF EJS Templates
Add comments emphasizing the order of steps in widget box remove() methods
Jason Grout -
Show More
@@ -79,6 +79,9 define([
79 79 },
80 80
81 81 remove: function() {
82 // We remove this widget before removing the children as an optimization
83 // we want to remove the entire container from the DOM first before
84 // removing each individual child separately.
82 85 BoxView.__super__.remove.apply(this, arguments);
83 86 this.children_views.remove();
84 87 },
@@ -128,6 +128,9 define([
128 128 },
129 129
130 130 remove: function() {
131 // We remove this widget before removing the children as an optimization
132 // we want to remove the entire container from the DOM first before
133 // removing each individual child separately.
131 134 AccordionView.__super__.remove.apply(this, arguments);
132 135 this.children_views.remove();
133 136 },
@@ -252,6 +255,9 define([
252 255 },
253 256
254 257 remove: function() {
258 // We remove this widget before removing the children as an optimization
259 // we want to remove the entire container from the DOM first before
260 // removing each individual child separately.
255 261 TabView.__super__.remove.apply(this, arguments);
256 262 this.children_views.remove();
257 263 },
General Comments 0
You need to be logged in to leave comments. Login now