Show More
@@ -666,6 +666,11 class Pretty(TextDisplayObject): | |||||
666 |
|
666 | |||
667 | class HTML(TextDisplayObject): |
|
667 | class HTML(TextDisplayObject): | |
668 |
|
668 | |||
|
669 | def __init__(self, data=None, url=None, filename=None, metadata=None): | |||
|
670 | if data and "<iframe " in data and "</iframe>" in data: | |||
|
671 | warnings.warn("Consider using IPython.display.IFrame instead") | |||
|
672 | super(HTML, self).__init__(data=data, url=url, filename=filename, metadata=metadata) | |||
|
673 | ||||
669 | def _repr_html_(self): |
|
674 | def _repr_html_(self): | |
670 | return self._data_and_metadata() |
|
675 | return self._data_and_metadata() | |
671 |
|
676 |
@@ -195,6 +195,14 def test_displayobject_repr(): | |||||
195 | j._show_mem_addr = False |
|
195 | j._show_mem_addr = False | |
196 | nt.assert_equal(repr(j), '<IPython.core.display.Javascript object>') |
|
196 | nt.assert_equal(repr(j), '<IPython.core.display.Javascript object>') | |
197 |
|
197 | |||
|
198 | @mock.patch('warnings.warn') | |||
|
199 | def test_encourage_iframe_over_html(m_warn): | |||
|
200 | display.HTML('<br />') | |||
|
201 | m_warn.assert_not_called() | |||
|
202 | ||||
|
203 | display.HTML('<iframe src="http://a.com"></iframe>') | |||
|
204 | m_warn.assert_called_with('Consider using IPython.display.IFrame instead') | |||
|
205 | ||||
198 | def test_progress(): |
|
206 | def test_progress(): | |
199 | p = display.ProgressBar(10) |
|
207 | p = display.ProgressBar(10) | |
200 | nt.assert_in('0/10',repr(p)) |
|
208 | nt.assert_in('0/10',repr(p)) |
General Comments 0
You need to be logged in to leave comments.
Login now