Fix for ticket: https://bugs.launchpad.net/bugs/361414

ipcluster, ipcontroller and ipengine now all call user_setup to make
sure that the ipython dir exists.  I also found some subtle bugs
about how the various ipython directories were being handled.

Now, all of these script call get_log_dir() and get_security_dir() to
make sure that these sub-dirs of ipythondir exist as well.

IPython/genutils.py

@@ -1008,6 +1008,16 b' def get_security_dir():'
         os.chmod(security_dir, 0700)
     return security_dir
         
+def get_log_dir():
+    """Get the IPython log directory.
+    
+    If the log directory does not exist, it is created.
+    """
+    log_dir = os.path.join(get_ipython_dir(), 'log')
+    if not os.path.isdir(log_dir):
+        os.mkdir(log_dir, 0777)
+    return log_dir
+
 #****************************************************************************
 # strings and text
 

IPython/kernel/__init__.py

@@ -15,10 +15,9 b' if they need blocking clients or in `asyncclient.py` if they want asynchronous,'
 deferred/Twisted using clients.
 """
 __docformat__ = "restructuredtext en"
-#-------------------------------------------------------------------------------
+#-----------------------------------------------------------------------------
 #  Copyright (C) 2008  The IPython Development Team
 #
 #  Distributed under the terms of the BSD License.  The full license is in
 #  the file COPYING, distributed as part of this software.
-#-------------------------------------------------------------------------------
-    
  No newline at end of file
+#-----------------------------------------------------------------------------
  No newline at end of file

IPython/kernel/config/__init__.py

@@ -15,6 +15,7 b' __docformat__ = "restructuredtext en"'
 # Imports
 #-------------------------------------------------------------------------------
 
+import os, sys
 from os.path import join as pjoin
 
 from IPython.external.configobj import ConfigObj
@@ -23,6 +24,7 b' from IPython.genutils import get_ipython_dir, get_security_dir'
 
 default_kernel_config = ConfigObj()
 
+# This will raise OSError if ipythondir doesn't exist.
 security_dir = get_security_dir()
 
 #-------------------------------------------------------------------------------

IPython/kernel/scripts/ipcluster.py

@@ -29,8 +29,21 b' from twisted.python import failure, log'
 
 from IPython.external import argparse
 from IPython.external import Itpl
-from IPython.genutils import get_ipython_dir, num_cpus
+from IPython.genutils import get_ipython_dir, get_log_dir, get_security_dir
+from IPython.genutils import num_cpus
 from IPython.kernel.fcutil import have_crypto
+
+# Create various ipython directories if they don't exist.
+# This must be done before IPython.kernel.config is imported.
+from IPython.iplib import user_setup
+if os.name == 'posix':
+    rc_suffix = ''
+else:
+    rc_suffix = '.ini'
+user_setup(get_ipython_dir(), rc_suffix, mode='install', interactive=False)
+get_log_dir()
+get_security_dir()
+
 from IPython.kernel.config import config_manager as kernel_config_manager
 from IPython.kernel.error import SecurityError, FileTimeoutError
 from IPython.kernel.fcutil import have_crypto

IPython/kernel/scripts/ipcontroller.py

@@ -38,6 +38,18 b' from IPython.kernel.error import SecurityError'
 from IPython.kernel import controllerservice
 from IPython.kernel.fcutil import check_furl_file_security
 
+# Create various ipython directories if they don't exist.
+# This must be done before IPython.kernel.config is imported.
+from IPython.iplib import user_setup
+from IPython.genutils import get_ipython_dir, get_log_dir, get_security_dir
+if os.name == 'posix':
+    rc_suffix = ''
+else:
+    rc_suffix = '.ini'
+user_setup(get_ipython_dir(), rc_suffix, mode='install', interactive=False)
+get_log_dir()
+get_security_dir()
+
 from IPython.kernel.config import config_manager as kernel_config_manager
 from IPython.config.cutils import import_item
 
@@ -116,7 +128,6 b' def make_client_service(controller_service, config):'
             # appears to other processes, the buffer has the flushed
             # and the file has been closed
             temp_furl_file = get_temp_furlfile(furl_file)
-            log.msg(temp_furl_file)
             client_tub.registerReference(ref, furlFile=temp_furl_file)
             os.rename(temp_furl_file, furl_file)
         
@@ -169,7 +180,6 b' def make_engine_service(controller_service, config):'
             # appears to other processes, the buffer has the flushed
             # and the file has been closed
             temp_furl_file = get_temp_furlfile(furl_file)
-            log.msg(temp_furl_file)
             engine_tub.registerReference(ref, furlFile=temp_furl_file)
             os.rename(temp_furl_file, furl_file)
         
@@ -342,12 +352,6 b' def init_config():'
         help="log file name (default is stdout)"
     )
     parser.add_option(
-        "--ipythondir",
-        type="string",
-        dest="ipythondir",
-        help="look for config files and profiles in this directory"
-    )
-    parser.add_option(
         "-r",
         action="store_true",
         dest="reuse_furls",
@@ -356,7 +360,6 b' def init_config():'
     
     (options, args) = parser.parse_args()
     
-    kernel_config_manager.update_config_obj_from_default_file(options.ipythondir)
     config = kernel_config_manager.get_config_obj()
     
     # Update with command line options

IPython/kernel/scripts/ipengine.py

@@ -33,6 +33,19 b' from IPython.kernel.fcutil import Tub, UnauthenticatedTub'
 from IPython.kernel.core.config import config_manager as core_config_manager
 from IPython.config.cutils import import_item
 from IPython.kernel.engineservice import EngineService
+
+# Create various ipython directories if they don't exist.
+# This must be done before IPython.kernel.config is imported.
+from IPython.iplib import user_setup
+from IPython.genutils import get_ipython_dir, get_log_dir, get_security_dir
+if os.name == 'posix':
+    rc_suffix = ''
+else:
+    rc_suffix = '.ini'
+user_setup(get_ipython_dir(), rc_suffix, mode='install', interactive=False)
+get_log_dir()
+get_security_dir()
+
 from IPython.kernel.config import config_manager as kernel_config_manager
 from IPython.kernel.engineconnector import EngineConnector
 
@@ -148,18 +161,9 b' def init_config():'
         dest="logfile",
         help="log file name (default is stdout)"
     )
-    parser.add_option(
-        "--ipythondir",
-        type="string",
-        dest="ipythondir",
-        help="look for config files and profiles in this directory"
-    )
     
     (options, args) = parser.parse_args()
     
-    kernel_config_manager.update_config_obj_from_default_file(options.ipythondir)
-    core_config_manager.update_config_obj_from_default_file(options.ipythondir)
-    
     kernel_config = kernel_config_manager.get_config_obj()
     # Now override with command line options
     if options.furl_file is not None:

IPython/tests/test_genutils.py

@@ -210,7 +210,6 b' def test_get_home_dir_7():'
     home_dir = genutils.get_home_dir()
     nt.assert_equal(home_dir, abspath(HOME_TEST_DIR))
 
-
 #
 # Tests for get_ipython_dir
 #
@@ -239,7 +238,6 b' def test_get_ipython_dir_3():'
     ipdir = genutils.get_ipython_dir()
     nt.assert_equal(ipdir, os.path.abspath(os.path.join("someplace", "_ipython")))
 
-
 #
 # Tests for get_security_dir
 #
@@ -249,6 +247,14 b' def test_get_security_dir():'
     """Testcase to see if we can call get_security_dir without Exceptions."""
     sdir = genutils.get_security_dir()
 
+#
+# Tests for get_log_dir
+#
+
+@with_enivronment
+def test_get_log_dir():
+    """Testcase to see if we can call get_log_dir without Exceptions."""
+    sdir = genutils.get_log_dir()
 
 #
 # Tests for popkey