##// END OF EJS Templates
Apply suggestions from code review...
Matthias Bussonnier -
Show More
@@ -191,7 +191,7 b' class BaseIPythonApplication(Application):'
191 This option was non-existing before IPython 8.0, and ipython_dir was added to
191 This option was non-existing before IPython 8.0, and ipython_dir was added to
192 sys path to allow import of extensions present there. This was historical
192 sys path to allow import of extensions present there. This was historical
193 baggage from when pip did not exist. This now default to false,
193 baggage from when pip did not exist. This now default to false,
194 but can bet to true for legacy reasons
194 but can be set to true for legacy reasons.
195 """).tag(config=True)
195 """).tag(config=True)
196
196
197 ipython_dir = Unicode(
197 ipython_dir = Unicode(
@@ -305,7 +305,7 b' class BaseIPythonApplication(Application):'
305 sys.path.remove(str_old)
305 sys.path.remove(str_old)
306 if self.add_ipython_dir_to_sys_path:
306 if self.add_ipython_dir_to_sys_path:
307 str_path = os.path.abspath(new)
307 str_path = os.path.abspath(new)
308 #sys.path.append(str_path)
308 sys.path.append(str_path)
309 ensure_dir_exists(new)
309 ensure_dir_exists(new)
310 readme = os.path.join(new, 'README')
310 readme = os.path.join(new, 'README')
311 readme_src = os.path.join(get_ipython_package_dir(), u'config', u'profile', 'README')
311 readme_src = os.path.join(get_ipython_package_dir(), u'config', u'profile', 'README')
General Comments 0
You need to be logged in to leave comments. Login now