Moving tests/test_magic.py and support files to core/tests.

IPython/core/tests/test_magic.py

@@ -1,249 +1,249 b''
 """Tests for various magic functions.
 
 Needs to be run by nose (to make ipython session available).
 """
 
 import os
 import sys
 import tempfile
 import types
 
 import nose.tools as nt
 
 from IPython.utils.platutils import find_cmd, get_long_path_name
 from IPython.testing import decorators as dec
 from IPython.testing import tools as tt
 
 #-----------------------------------------------------------------------------
 # Test functions begin
 
 def test_rehashx():
     # clear up everything
     _ip.IP.alias_table.clear()
     del _ip.db['syscmdlist']
     
     _ip.magic('rehashx')
     # Practically ALL ipython development systems will have more than 10 aliases
 
     assert len(_ip.IP.alias_table) > 10
     for key, val in _ip.IP.alias_table.items():
         # we must strip dots from alias names
         assert '.' not in key
 
     # rehashx must fill up syscmdlist
     scoms = _ip.db['syscmdlist']
     assert len(scoms) > 10
 
 
 def doctest_hist_f():
     """Test %hist -f with temporary filename.
 
     In [9]: import tempfile
 
     In [10]: tfile = tempfile.mktemp('.py','tmp-ipython-')
 
     In [11]: %history -n -f $tfile 3
     """
 
 
 def doctest_hist_r():
     """Test %hist -r
 
     XXX - This test is not recording the output correctly.  Not sure why...
 
     In [6]: x=1
 
     In [7]: hist -n -r 2
     x=1  # random
     hist -n -r 2  # random
     """
 
 # This test is known to fail on win32.
 # See ticket https://bugs.launchpad.net/bugs/366334
 def test_obj_del():
     """Test that object's __del__ methods are called on exit."""
     test_dir = os.path.dirname(__file__)
     del_file = os.path.join(test_dir,'obj_del.py')
     ipython_cmd = find_cmd('ipython')
     out = _ip.IP.getoutput('%s %s' % (ipython_cmd, del_file))
     nt.assert_equals(out,'obj_del.py: object A deleted')
 
 
 def test_shist():
     # Simple tests of ShadowHist class - test generator.
     import os, shutil, tempfile
 
     from IPython.Extensions import pickleshare
-    from IPython.history import ShadowHist
+    from IPython.core.history import ShadowHist
     
     tfile = tempfile.mktemp('','tmp-ipython-')
     
     db = pickleshare.PickleShareDB(tfile)
     s = ShadowHist(db)
     s.add('hello')
     s.add('world')
     s.add('hello')
     s.add('hello')
     s.add('karhu')
 
     yield nt.assert_equals,s.all(),[(1, 'hello'), (2, 'world'), (3, 'karhu')]
     
     yield nt.assert_equal,s.get(2),'world'
     
     shutil.rmtree(tfile)
     
 @dec.skipif_not_numpy
 def test_numpy_clear_array_undec():
     _ip.ex('import numpy as np')
     _ip.ex('a = np.empty(2)')
     
     yield nt.assert_true,'a' in _ip.user_ns
     _ip.magic('clear array')
     yield nt.assert_false,'a' in _ip.user_ns
     
 
 @dec.skip()
 def test_fail_dec(*a,**k):
     yield nt.assert_true, False
 
 @dec.skip('This one shouldn not run')
 def test_fail_dec2(*a,**k):
     yield nt.assert_true, False
 
 @dec.skipknownfailure
 def test_fail_dec3(*a,**k):
     yield nt.assert_true, False
 
 
 def doctest_refbug():
     """Very nasty problem with references held by multiple runs of a script.
     See: https://bugs.launchpad.net/ipython/+bug/269966
 
     In [1]: _ip.IP.clear_main_mod_cache()
     
     In [2]: run refbug
 
     In [3]: call_f()
     lowercased: hello
 
     In [4]: run refbug
 
     In [5]: call_f()
     lowercased: hello
     lowercased: hello
     """
 
 #-----------------------------------------------------------------------------
 # Tests for %run
 #-----------------------------------------------------------------------------
 
 # %run is critical enough that it's a good idea to have a solid collection of
 # tests for it, some as doctests and some as normal tests.
 
 def doctest_run_ns():
     """Classes declared %run scripts must be instantiable afterwards.
 
     In [11]: run tclass foo
 
     In [12]: isinstance(f(),foo)
     Out[12]: True
     """
 
     
 def doctest_run_ns2():
     """Classes declared %run scripts must be instantiable afterwards.
 
     In [4]: run tclass C-first_pass
 
     In [5]: run tclass C-second_pass
     tclass.py: deleting object: C-first_pass
     """
 
 @dec.skip_win32
 def doctest_run_builtins():
     """Check that %run doesn't damage __builtins__ via a doctest.
 
     This is similar to the test_run_builtins, but I want *both* forms of the
     test to catch any possible glitches in our testing machinery, since that
     modifies %run somewhat.  So for this, we have both a normal test (below)
     and a doctest (this one).
 
     In [1]: import tempfile
 
     In [2]: bid1 = id(__builtins__)
 
     In [3]: f = tempfile.NamedTemporaryFile()
 
     In [4]: f.write('pass\\n')
 
     In [5]: f.flush()
 
     In [6]: print 'B1:',type(__builtins__)
     B1: <type 'module'>
 
     In [7]: %run $f.name
 
     In [8]: bid2 = id(__builtins__)
 
     In [9]: print 'B2:',type(__builtins__)
     B2: <type 'module'>
 
     In [10]: bid1 == bid2
     Out[10]: True
     """
 
 # For some tests, it will be handy to organize them in a class with a common
 # setup that makes a temp file
 
 class TestMagicRun(object):
 
     def setup(self):
         """Make a valid python temp file."""
         f = tempfile.NamedTemporaryFile()
         f.write('pass\n')
         f.flush()
         self.tmpfile = f
 
     def run_tmpfile(self):
         # This fails on Windows if self.tmpfile.name has spaces or "~" in it.
         # See below and ticket https://bugs.launchpad.net/bugs/366353
         _ip.magic('run %s' % self.tmpfile.name)
 
     # See https://bugs.launchpad.net/bugs/366353
     @dec.skip_if_not_win32
     def test_run_tempfile_path(self):
         tt.assert_equals(True,False,"%run doesn't work with tempfile paths on win32.")
 
     # See https://bugs.launchpad.net/bugs/366353
     @dec.skip_win32
     def test_builtins_id(self):
         """Check that %run doesn't damage __builtins__ """
 
         # Test that the id of __builtins__ is not modified by %run
         bid1 = id(_ip.user_ns['__builtins__'])
         self.run_tmpfile()
         bid2 = id(_ip.user_ns['__builtins__'])
         tt.assert_equals(bid1, bid2)
 
     # See https://bugs.launchpad.net/bugs/366353
     @dec.skip_win32
     def test_builtins_type(self):
         """Check that the type of __builtins__ doesn't change with %run.
         
         However, the above could pass if __builtins__ was already modified to
         be a dict (it should be a module) by a previous use of %run.  So we
         also check explicitly that it really is a module:
         """
         self.run_tmpfile()
         tt.assert_equals(type(_ip.user_ns['__builtins__']),type(sys))
 
     # See https://bugs.launchpad.net/bugs/366353
     @dec.skip_win32
     def test_prompts(self):
         """Test that prompts correctly generate after %run"""
         self.run_tmpfile()
         p2 = str(_ip.IP.outputcache.prompt2).strip()
         nt.assert_equals(p2[:3], '...')
 
     def teardown(self):
         self.tmpfile.close()

docs/source/development/reorg.txt

@@ -1,270 +1,263 b''
 =============================
 IPython module reorganization
 =============================
 
 Currently, IPython has many top-level modules that serve many different purposes.
 The lack of organization make it very difficult for developers to work on IPython
 and understand its design. This document contains notes about how we will reorganize
 the modules into sub-packages.
 
 .. warning::
 
     This effort will possibly break third party packages that use IPython as
     a library or hack on the IPython internals.
 
 .. warning::
 
     This effort will result in the removal from IPython of certain modules
     that are not used anymore, don't currently work, are unmaintained, etc.
 
 
 Current subpackges
 ==================
 
 IPython currently has the following sub-packages:
 
 * :mod:`IPython.config`
 
 * :mod:`IPython.Extensions`
 
 * :mod:`IPython.external`
 
 * :mod:`IPython.frontend`
 
 * :mod:`IPython.gui`
 
 * :mod:`IPython.kernel`
 
 * :mod:`IPython.testing`
 
 * :mod:`IPython.tests`
 
 * :mod:`IPython.tools`
 
 * :mod:`IPython.UserConfig`
 
 New Subpackages to be created
 =============================
 
 We propose to create the following new sub-packages:
 
 * :mod:`IPython.core`. This sub-package will contain the core of the IPython
   interpreter, but none of its extended capabilities.
 
 * :mod:`IPython.lib`. IPython has many extended capabilities that are not part
   of the IPython core. These things will go here.  Any better names than 
   :mod:`IPython.lib`?
 
 * :mod:`IPython.utils`. This sub-package will contain anything that might
   eventually be found in the Python standard library, like things in
   :mod:`genutils`. Each sub-module in this sub-package should contain
   functions and classes that serve a single purpose.
 
 * :mod:`IPython.deathrow`. This is for code that is untested and/or rotting
   and needs to be removed from IPython. Eventually all this code will either
   i) be revived by someone willing to maintain it with tests and docs and
   re-included into IPython or 2) be removed from IPython proper, but put into
   a separate top-level (not IPython) package that we keep around. No new code
   will be allowed here.
 
 * :mod:`IPython.quarantine`.  This is for code that doesn't meet IPython's 
   standards, but that we plan on keeping.  To be moved out of this sub-package
   a module needs to have a maintainer, tests and documentation.
 
 Prodecure
 =========
 
 1. Move the file to its new location with its new name.
 2. Rename all import statements to reflect the change.
 3. Run PyFlakes on each changes module.
 3. Add tests/test_imports.py to test it.
 
 Need to modify iptests to properly skip modules that are no longer top
 level modules.
 
 Need to update the top level IPython/__init__.py file.
 
 Where things will be moved
 ==========================
 
+Top-level modules:
+
 * :file:`background_jobs.py`.  Move to :file:`IPython/lib/backgroundjobs.py`.
 
 * :file:`ColorANSI.py`.  Move to :file:`IPython/utils/coloransi.py`.
 
 * :file:`completer.py`.  Move to :file:`IPython/core/completer.py`.
 
 * :file:`ConfigLoader.py`.  Move to :file:`IPython/config/configloader.py`.
 
 * :file:`CrashHandler.py`.  Move to :file:`IPython/core/crashhandler`.
 
 * :file:`Debugger.py`.  Move to :file:`IPython/core/debugger.py`.
 
 * :file:`deep_reload.py`.  Move to :file:`IPython/lib/deepreload.py`.
 
 * :file:`demo.py`.  Move to :file:`IPython/lib/demo.py`.
 
 * :file:`DPyGetOpt.py`.  Move to :mod:`IPython.utils` and replace with newer options parser.
 
 * :file:`dtutils.py`.  Move to :file:`IPython.deathrow`.
 
 * :file:`excolors.py`.  Move to :file:`IPython.core` or :file:`IPython.config`.
   Maybe move to :mod:`IPython.lib` or :mod:`IPython.python`?
 
 * :file:`FakeModule.py`.  Move to :file:`IPython/core/fakemodule.py`.
 
 * :file:`generics.py`.  Move to :file:`IPython.python`.
 
 * :file:`genutils.py`.  Move to :file:`IPython.utils`.
 
 * :file:`Gnuplot2.py`.  Move to :file:`IPython.sandbox`.
 
 * :file:`GnuplotInteractive.py`.  Move to :file:`IPython.sandbox`.
 
 * :file:`GnuplotRuntime.py`.  Move to :file:`IPython.sandbox`.
 
 * :file:`numutils.py`.  Move to :file:`IPython.sandbox`.
 
 * :file:`twshell.py`.  Move to :file:`IPython.sandbox`.
 
 * :file:`Extensions`. This needs to be gone through separately.  Minimally,
   the package should be renamed to :file:`extensions`.
 
 * :file:`history.py`.  Move to :file:`IPython.core`.
 
 * :file:`hooks.py`.  Move to :file:`IPython.core`.
 
 * :file:`ipapi.py`.  Move to :file:`IPython.core`.
 
 * :file:`iplib.py`.  Move to :file:`IPython.core`.
 
 * :file:`ipmaker.py`:  Move to :file:`IPython.core`.
 
 * :file:`ipstruct.py`.  Move to :file:`IPython.python`.
 
 * :file:`irunner.py`.  Move to :file:`IPython.scripts`. ???
 
 * :file:`Itpl.py`. Move to :file:`deathrow/Itpl.py`. Copy already in
   :file:`IPython.external`.
 
 * :file:`Logger.py`.  Move to :file:`IPython/core/logger.py`.
 
 * :file:`macro.py`.  Move to :file:`IPython.core`.
 
 * :file:`Magic.py`.  Move to :file:`IPython/core/magic.py`.
 
 * :file:`OInspect.py`.  Move to :file:`IPython/core/oinspect.py`.
 
 * :file:`OutputTrap.py`.  Move to :file:`IPython/core/outputtrap.py`.
 
 * :file:`platutils.py`.  Move to :file:`IPython.python`.
 
 * :file:`platutils_dummy.py`.  Move to :file:`IPython.python`.
 
 * :file:`platutils_posix.py`.  Move to :file:`IPython.python`.
 
 * :file:`platutils_win32.py`.  Move to :file:`IPython.python`.
 
 * :file:`prefilter.py`:  Move to :file:`IPython.core`.
 
 * :file:`Prompts.py`.  Move to :file:`IPython/core/prompts.py` or
   :file:`IPython/frontend/prompts.py`.
 
 * :file:`PyColorize.py`. Replace with pygments? If not, move to
   :file:`IPython/core/pycolorize.py`. Maybe move to :mod:`IPython.lib` or
   :mod:`IPython.python`?
 
 * :file:`Release.py`.  Move to ??? or remove?
 
 * :file:`rlineimpl.py`.  Move to :file:`IPython.core`.
 
 * :file:`shadowns.py`.  Move to :file:`IPython.core`.
 
 * :file:`Shell.py`.  Move to :file:`IPython.core.shell.py` or
   :file:`IPython/frontend/shell.py`.
 
 * :file:`shellglobals.py`.  Move to :file:`IPython.core`.
 
 * :file:`strdispatch.py`.  Move to :file:`IPython.python`.
 
+* :file:`twshell.py`.  Move to :file:`IPython.sandbox`.
+
+* :file:`ultraTB.py`.  Move to :file:`IPython/core/ultratb.py`.
+
+* :file:`upgrade_dir.py`.  Move to :file:`IPython/utils/upgradedir.py`.
+
+* :file:`usage.py`.  Move to :file:`IPython.core`.
+
+* :file:`wildcard.py`.  Move to :file:`IPython.utils`.
+
+* :file:`winconsole.py`.  Move to :file:`IPython.utils`.
+
+Top-level sub-packages:
+
 * :file:`testing`.  Good where it is.
 
 * :file:`tests`.  Good where it is.
 
 * :file:`tools`.  Things in here need to be looked at and moved elsewhere like
-    :file:`IPython.python`.
+    :file:`IPython.utils`.
 
 * :file:`UserConfig`.  Move to a subdirectory of :file:`IPython.config`.
 
-
-
-
 * :file:`config`.  Good where it is!
 
 * :file:`external`.  Good where it is!
 
 * :file:`frontend`.  Good where it is!
 
 
 
 * :file:`gui`.  Eventually this should be moved to a subdir of   
   :file:`IPython.frontend`.
 
-
-
-
-
-
-
-
-
-
-
 * :file:`kernel`.  Good where it is.
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
-* :file:`twshell.py`.  Move to :file:`IPython.sandbox`.
-
-* :file:`ultraTB.py`.  Move to :file:`IPython/core/ultratb.py`.
-
-* :file:`upgrade_dir.py`.  Move to :file:`IPython/utils/upgradedir.py`.
-
-* :file:`usage.py`.  Move to :file:`IPython.core`.
-
-* :file:`wildcard.py`.  Move to :file:`IPython.utils`.
 
-* :file:`winconsole.py`.  Move to :file:`IPython.lib`.
 
 Other things
 ============
 
 When these files are moved around, a number of other things will happen at the same time:
 
 1. Test files will be created for each module in IPython. Minimally, all
    modules will be imported as a part of the test. This will serve as a 
    test of the module reorganization. These tests will be put into new
    :file:`tests` subdirectories that each package will have.
 
 2. PyFlakes and other code checkers will be run to look for problems.
 
 3. Modules will be renamed to comply with PEP 8 naming conventions:  all
    lowercase and no special characters like ``-`` or ``_``.
 
 4. Existing tests will be moved to the appropriate :file:`tests`
    subdirectories.