Merge pull request #13204 from DimitriPapadopoulos/mutable_default_arguments

Do not use mutables as default arguments

docs/sphinxext/github.py

@@ -51,7 +51,7 b' def make_link_node(rawtext, app, type, slug, options):'
                            **options)
     return node
 
-def ghissue_role(name, rawtext, text, lineno, inliner, options={}, content=[]):
+def ghissue_role(name, rawtext, text, lineno, inliner, options=None, content=None):
     """Link to a GitHub issue.
 
     Returns 2 part tuple containing list of nodes to insert into the
@@ -66,6 +66,8 b' def ghissue_role(name, rawtext, text, lineno, inliner, options={}, content=[]):'
     :param options: Directive options for customization.
     :param content: The directive content for customization.
     """
+    if options is None:
+        options = {}
 
     try:
         issue_num = int(text)
@@ -92,7 +94,7 b' def ghissue_role(name, rawtext, text, lineno, inliner, options={}, content=[]):'
     node = make_link_node(rawtext, app, category, str(issue_num), options)
     return [node], []
 
-def ghuser_role(name, rawtext, text, lineno, inliner, options={}, content=[]):
+def ghuser_role(name, rawtext, text, lineno, inliner, options=None, content=None):
     """Link to a GitHub user.
 
     Returns 2 part tuple containing list of nodes to insert into the
@@ -107,13 +109,16 b' def ghuser_role(name, rawtext, text, lineno, inliner, options={}, content=[]):'
     :param options: Directive options for customization.
     :param content: The directive content for customization.
     """
+    if options is None:
+        options = {}
+
     app = inliner.document.settings.env.app
     #info('user link %r' % text)
     ref = 'https://www.github.com/' + text
     node = nodes.reference(rawtext, text, refuri=ref, **options)
     return [node], []
 
-def ghcommit_role(name, rawtext, text, lineno, inliner, options={}, content=[]):
+def ghcommit_role(name, rawtext, text, lineno, inliner, options=None, content=None):
     """Link to a GitHub commit.
 
     Returns 2 part tuple containing list of nodes to insert into the
@@ -128,6 +133,9 b' def ghcommit_role(name, rawtext, text, lineno, inliner, options={}, content=[]):'
     :param options: Directive options for customization.
     :param content: The directive content for customization.
     """
+    if options is None:
+        options = {}
+
     app = inliner.document.settings.env.app
     #info('user link %r' % text)
     try: