Merge pull request #11139 from jdemeyer/signature

signature: use inspect instead of type checks

IPython/utils/_signatures.py

@@ -21,6 +21,7 b' import itertools'
 import functools
 import re
 import types
+import inspect
 
 
 # patch for single-file
@@ -71,7 +72,7 b' def signature(obj):'
     if not callable(obj):
         raise TypeError('{0!r} is not a callable object'.format(obj))
 
-    if isinstance(obj, types.MethodType):
+    if inspect.ismethod(obj):
         if obj.__self__ is None:
             # Unbound method - treat it as a function (no distinction in Py 3)
             obj = obj.__func__
@@ -96,7 +97,7 b' def signature(obj):'
     else:
         return signature(wrapped)
 
-    if isinstance(obj, types.FunctionType):
+    if inspect.isfunction(obj):
         return Signature.from_function(obj)
 
     if isinstance(obj, functools.partial):
@@ -511,7 +512,7 b' class Signature(object):'
     def from_function(cls, func):
         '''Constructs Signature for the given python function'''
 
-        if not isinstance(func, types.FunctionType):
+        if not inspect.isfunction(func):
             raise TypeError('{0!r} is not a Python function'.format(func))
 
         Parameter = cls._parameter_cls