Show More
@@ -28,6 +28,7 jobs: | |||||
28 | - name: Install dependencies |
|
28 | - name: Install dependencies | |
29 | run: | |
|
29 | run: | | |
30 | python -m pip install --upgrade pip |
|
30 | python -m pip install --upgrade pip | |
|
31 | # when changing the versions please update CONTRIBUTING.md too | |||
31 | pip install --only-binary ':all:' darker==1.5.1 black==22.10.0 |
|
32 | pip install --only-binary ':all:' darker==1.5.1 black==22.10.0 | |
32 | - name: Lint with darker |
|
33 | - name: Lint with darker | |
33 | run: | |
|
34 | run: | |
@@ -92,8 +92,7 pytest IPython/core/tests/test_alias.py::test_alias_lifecycle | |||||
92 |
|
92 | |||
93 | ## Code style |
|
93 | ## Code style | |
94 |
|
94 | |||
95 | * Before committing, run `darker -r 60625f241f298b5039cb2debc365db38aa7bb522 <file path>` to apply selective `black` formatting on modified regions using [darker](https://github.com/akaihola/darker). |
|
95 | * Before committing, run `darker -r 60625f241f298b5039cb2debc365db38aa7bb522 <file path>` to apply selective `black` formatting on modified regions using [darker](https://github.com/akaihola/darker)==1.5.1 and black==22.10.0 | |
96 | * For newly added modules or refactors, please enable static typing analysis with `mypy` for the modified module by adding the file path in [`mypy.yml`](https://github.com/ipython/ipython/blob/main/.github/workflows/mypy.yml) workflow. |
|
|||
97 | * As described in the pull requests section, please avoid excessive formatting changes; if a formatting-only commit is necessary, consider adding its hash to [`.git-blame-ignore-revs`](https://github.com/ipython/ipython/blob/main/.git-blame-ignore-revs) file. |
|
96 | * As described in the pull requests section, please avoid excessive formatting changes; if a formatting-only commit is necessary, consider adding its hash to [`.git-blame-ignore-revs`](https://github.com/ipython/ipython/blob/main/.git-blame-ignore-revs) file. | |
98 |
|
97 | |||
99 | ## Documentation |
|
98 | ## Documentation |
General Comments 0
You need to be logged in to leave comments.
Login now