##// END OF EJS Templates
Merge pull request #10239 from segevfiner/editorhooks-wait-fix...
Thomas Kluyver -
r23296:e311b1db merge
parent child Browse files
Show More
@@ -53,7 +53,7 b' def install_editor(template, wait=False):'
53 if sys.platform.startswith('win'):
53 if sys.platform.startswith('win'):
54 cmd = shlex.split(cmd)
54 cmd = shlex.split(cmd)
55 proc = subprocess.Popen(cmd, shell=True)
55 proc = subprocess.Popen(cmd, shell=True)
56 if wait and proc.wait() != 0:
56 if proc.wait() != 0:
57 raise TryNext()
57 raise TryNext()
58 if wait:
58 if wait:
59 py3compat.input("Press Enter when done editing:")
59 py3compat.input("Press Enter when done editing:")
@@ -14,6 +14,7 b' def test_install_editor():'
14 'args': args,
14 'args': args,
15 'kwargs': kwargs,
15 'kwargs': kwargs,
16 })
16 })
17 return mock.MagicMock(**{'wait.return_value': 0})
17 editorhooks.install_editor('foo -l {line} -f {filename}', wait=False)
18 editorhooks.install_editor('foo -l {line} -f {filename}', wait=False)
18
19
19 with mock.patch('subprocess.Popen', fake_popen):
20 with mock.patch('subprocess.Popen', fake_popen):
General Comments 0
You need to be logged in to leave comments. Login now