fixes issue #166, made clone-uri use the pylons build in url generators, that way it's more safe.

rhodecode/controllers/shortlog.py

@@ -25,7 +25,7
 
 import logging
 
-from pylons import tmpl_context as c, request
+from pylons import tmpl_context as c, request, url
 
 from rhodecode.lib.auth import LoginRequired, HasRepoPermissionAnyDecorator
 from rhodecode.lib.base import BaseRepoController, render
@@ -42,10 +42,16 class ShortlogController(BaseRepoControl
     def __before__(self):
         super(ShortlogController, self).__before__()
 
-    def index(self):
+    def index(self, repo_name):
         p = int(request.params.get('page', 1))
+        size = int(request.params.get('size', 20))
+
+        def url_generator(**kw):
+            return url('shortlog_home', repo_name=repo_name, size=size, **kw)
+
         c.repo_changesets = RepoPage(c.rhodecode_repo, page=p,
-                                     items_per_page=20)
+                                                       items_per_page=size,
+                                                       url=url_generator)
         c.shortlog_data = render('shortlog/shortlog_data.html')
         if request.params.get('partial'):
             return c.shortlog_data

rhodecode/controllers/summary.py

@@ -70,7 +70,7 class SummaryController(BaseRepoControll
                                                 self.rhodecode_user.user_id)
 
         def url_generator(**kw):
-            return url('shortlog_home', repo_name=repo_name, **kw)
+            return url('shortlog_home', repo_name=repo_name, size=10, **kw)
 
         c.repo_changesets = RepoPage(c.rhodecode_repo, page=1,
                                      items_per_page=10, url=url_generator)
@@ -83,13 +83,18 class SummaryController(BaseRepoControll
             username = str(self.rhodecode_user.username)
             password = '@'
 
-        uri = u'%(proto)s://%(user)s%(pass)s%(host)s%(prefix)s/%(repo_name)s' \
-                                    % {'proto': e.get('wsgi.url_scheme'),
-                                       'user': username,
-                                       'pass': password,
-                                       'host': e.get('HTTP_HOST'),
-                                       'prefix': e.get('SCRIPT_NAME'),
-                                       'repo_name': repo_name, }
+        if e.get('wsgi.url_scheme') == 'https':
+            split_s = 'https://'
+        else:
+            split_s = 'http://'
+
+        qualified_uri = [split_s] + [url.current(qualified=True)\
+                                     .split(split_s)[-1]]
+        uri = u'%(proto)s%(user)s%(pass)s%(rest)s' \
+                % {'user': username,
+                     'pass': password,
+                     'proto': qualified_uri[0],
+                     'rest': qualified_uri[1]}
         c.clone_repo_url = uri
         c.repo_tags = OrderedDict()
         for name, hash in c.rhodecode_repo.tags.items()[:10]:
@@ -133,8 +138,8 class SummaryController(BaseRepoControll
             c.commit_data = stats.commit_activity
             c.overview_data = stats.commit_activity_combined
 
-            lang_stats = [(x, {"count":y,
-                               "desc":LANGUAGES_EXTENSIONS_MAP.get(x)})
+            lang_stats = [(x, {"count": y,
+                               "desc": LANGUAGES_EXTENSIONS_MAP.get(x)})
                           for x, y in lang_stats.items()]
             print lang_stats