implements #293 gravatar link should be disabled when use_gravatar = false

rhodecode/lib/base.py

@@ -11,6 +11,7 b' from pylons.templating import render_mak'
 from paste.deploy.converters import asbool
 
 from rhodecode import __version__
+from rhodecode.lib import str2bool
 from rhodecode.lib.auth import AuthUser, get_container_username
 from rhodecode.lib.utils import get_repo_slug
 from rhodecode.model import meta
@@ -25,6 +26,7 b' class BaseController(WSGIController):'
     def __before__(self):
         c.rhodecode_version = __version__
         c.rhodecode_name = config.get('rhodecode_title')
+        c.use_gravatar = str2bool(config.get('use_gravatar'))
         c.ga_code = config.get('rhodecode_ga_code')
         c.repo_name = get_repo_slug(request)
         c.backends = BACKENDS.keys()

rhodecode/lib/helpers.py

@@ -454,9 +454,8 b' HasRepoPermissionAny, HasRepoPermissionA'
 #==============================================================================
 
 def gravatar_url(email_address, size=30):
-    if not str2bool(config['app_conf'].get('use_gravatar')) or \
-            not email_address or \
-            email_address == '[e-mail]':
+    if (not str2bool(config['app_conf'].get('use_gravatar')) or
+        not email_address or email_address == '[e-mail]'):
         return url("/images/user%s.png" % size)
 
     ssl_enabled = 'https' == request.environ.get('wsgi.url_scheme')

rhodecode/templates/admin/users/user_edit.html

@@ -30,9 +30,12 b''
            <div class="gravatar_box">
                <div class="gravatar"><img alt="gravatar" src="${h.gravatar_url(c.user.email)}"/></div>
                <p>
-               <strong>${_('Change your avatar at')} <a href="http://gravatar.com">gravatar.com</a></strong><br/> 
-               ${_('Using')} ${c.user.email}
-               </p>
+                %if c.use_gravatar:
+                <strong>${_('Change your avatar at')} <a href="http://gravatar.com">gravatar.com</a></strong>
+                <br/>${_('Using')} ${c.user.email}
+                %else:
+                <br/>${c.user.email}
+                %endif 
            </div>
         </div>
         <div class="field">

rhodecode/templates/admin/users/user_edit_my_account.html

@@ -29,8 +29,12 b''
                 <div class="gravatar_box">
                     <div class="gravatar"><img alt="gravatar" src="${h.gravatar_url(c.user.email)}"/></div>
                     <p>
-                    <strong>${_('Change your avatar at')} <a href="http://gravatar.com">gravatar.com</a></strong><br/> 
-                    ${_('Using')} ${c.user.email}
+                    %if c.use_gravatar:
+                    <strong>${_('Change your avatar at')} <a href="http://gravatar.com">gravatar.com</a></strong>
+                    <br/>${_('Using')} ${c.user.email}
+                    %else:
+                    <br/>${c.user.email}
+                    %endif 
                     </p>
                 </div>
              </div>