##// END OF EJS Templates
simplified compare url logic for outside repos
marcink -
r2245:2d35bbff codereview
parent child Browse files
Show More
@@ -48,8 +48,6 class CompareController(BaseRepoControll
48 """
48 """
49 Parse the org...other string
49 Parse the org...other string
50 Possible formats are `(branch|book|tag):<name>...(branch|book|tag):<othername>`
50 Possible formats are `(branch|book|tag):<name>...(branch|book|tag):<othername>`
51 or using a repo <empty>...(repo:</rhodecode/path/to/other)
52
53
51
54 :param ref: <orginal_reference>...<other_reference>
52 :param ref: <orginal_reference>...<other_reference>
55 :type ref: str
53 :type ref: str
@@ -62,12 +60,11 class CompareController(BaseRepoControll
62 return _repo, (name, val)
60 return _repo, (name, val)
63
61
64 def other_parser(other):
62 def other_parser(other):
63 _other_repo = request.GET.get('repo')
65 _repo = org_repo
64 _repo = org_repo
66 name, val = other.split(':')
65 name, val = other.split(':')
67 if 'repo' in other:
66 if _other_repo:
68 _repo = val
67 _repo = _other_repo #TODO: do an actual repo loookup within rhodecode
69 name = 'branch'
70 val = c.rhodecode_repo.DEFAULT_BRANCH_NAME
71
68
72 return _repo, (name, val)
69 return _repo, (name, val)
73
70
General Comments 0
You need to be logged in to leave comments. Login now