#71 code review

 - added delete of comments by owner or admin

rhodecode/config/routing.py

@@ -352,7 +352,7 b' def make_map(config):'
 
     rmap.connect('changeset_comment_delete', '/{repo_name:.*}/changeset/comment/{comment_id}/delete',
                 controller='changeset', action='delete_comment',
-                conditions=dict(function=check_repo))
+                conditions = dict(function=check_repo, method=["DELETE"]))
 
     rmap.connect('raw_changeset_home',
                  '/{repo_name:.*}/raw-changeset/{revision}',

rhodecode/controllers/changeset.py

@@ -44,6 +44,7 b' from vcs.exceptions import RepositoryErr'
     ChangesetDoesNotExistError
 from vcs.nodes import FileNode
 from vcs.utils import diffs as differ
+from webob.exc import HTTPForbidden
 
 log = logging.getLogger(__name__)
 
@@ -278,8 +279,13 b' class ChangesetController(BaseRepoContro'
                               revision=revision))
 
     @jsonify
-    @HasRepoPermissionAnyDecorator('hg.admin', 'repository.admin')
     def delete_comment(self, comment_id):
-        ccmodel = ChangesetCommentsModel()
-        ccmodel.delete(comment_id=comment_id)
-        return True
+        co = ChangesetComment.get(comment_id)
+        if (h.HasPermissionAny('hg.admin', 'repository.admin')() or
+            co.author.user_id == c.rhodecode_user.user_id):
+            ccmodel = ChangesetCommentsModel()
+            ccmodel.delete(comment_id=comment_id)
+            return True
+        else:
+            raise HTTPForbidden()
+

rhodecode/public/css/style.css

@@ -3263,9 +3263,8 b' div.rst-block pre {'
 }
 
 .comments .comment .text {
-    margin-top: 7px;
-    padding: 6px;
-    padding-bottom: 13px;
+    padding: 8px 6px 6px 14px;
+    background-color: #FAFAFA;
 }
 
 .comments .comments-number{
@@ -3330,6 +3329,6 b' form.comment-form {'
 }
 
 .comment .buttons {
-    float: right;
-    display: none;
-}
+    position: absolute;
+    right:40px;
+}

rhodecode/public/js/rhodecode.js

@@ -286,5 +286,15 b' var q_filter = function(target,nodes,dis'
 	}	
 }
 
+var ajaxPOST = function(url,postData,success) {
+    var sUrl = url;
+    var callback = {
+        success: success,
+        failure: function (o) {
+            alert("error");
+        },
+    };
+    var postData = postData;
+    var request = YAHOO.util.Connect.asyncRequest('POST', sUrl, callback, postData);
+};
 
-

rhodecode/templates/changeset/changeset.html

@@ -158,6 +158,17 b''
         </div>
         %endif
     </div>
-    
+    <script type="text/javascript">
+      var deleteComment = function(comment_id){
+
+          var url = "${url('changeset_comment_delete',repo_name=c.repo_name,comment_id='__COMMENT_ID__')}".replace('__COMMENT_ID__',comment_id);
+          var postData = '_method=delete';
+          var success = function(o){
+              var n = YUD.get('comment-'+comment_id);
+              n.parentNode.removeChild(n);
+          }
+          ajaxPOST(url,postData,success);
+      } 
+    </script> 
   </div>	
 </%def>

rhodecode/templates/changeset/changeset_file_comment.html

@@ -22,7 +22,7 b''
   	<div class="text">
   		%if h.HasPermissionAny('hg.admin', 'repository.admin')() or co.author.user_id == c.rhodecode_user.user_id:
   			<div class="buttons">
-  				<a href="javascript:void(0);" onClick="deleteComment(${co.comment_id})" class="">${_('Delete')}</a>
+  				<span onClick="deleteComment(${co.comment_id})" class="delete-comment ui-button-small">${_('Delete')}</span>
   			</div>
   		%endif
   		${h.rst(co.text)|n}