usage of request.GET is now more consistent

rhodecode/controllers/admin/admin.py

@@ -136,7 +136,7 b' class AdminController(BaseController):'
 
         users_log = users_log.order_by(UserLog.action_date.desc())
 
-        p = safe_int(request.params.get('page', 1), 1)
+        p = safe_int(request.GET.get('page', 1), 1)
 
         def url_generator(**kw):
             return url.current(filter=c.search_term, **kw)

rhodecode/controllers/admin/notifications.py

@@ -64,7 +64,7 b' class NotificationsController(BaseContro'
         notif = NotificationModel().get_for_user(self.rhodecode_user.user_id,
                                             filter_=request.GET.getall('type'))
 
-        p = safe_int(request.params.get('page', 1), 1)
+        p = safe_int(request.GET.get('page', 1), 1)
         c.notifications = Page(notif, page=p, items_per_page=10)
         c.pull_request_type = Notification.TYPE_PULL_REQUEST
         c.comment_type = [Notification.TYPE_CHANGESET_COMMENT,

rhodecode/controllers/changelog.py

@@ -54,20 +54,16 b' class ChangelogController(BaseRepoContro'
     def index(self):
         limit = 100
         default = 20
-        if request.params.get('size'):
-            try:
-                int_size = int(request.params.get('size'))
-            except ValueError:
-                int_size = default
-            c.size = max(min(int_size, limit), 1)
+        if request.GET.get('size'):
+            c.size = max(min(safe_int(request.GET.get('size')), limit), 1)
             session['changelog_size'] = c.size
             session.save()
         else:
             c.size = int(session.get('changelog_size', default))
         # min size must be 1
         c.size = max(c.size, 1)
-        p = safe_int(request.params.get('page', 1), 1)
-        branch_name = request.params.get('branch', None)
+        p = safe_int(request.GET.get('page', 1), 1)
+        branch_name = request.GET.get('branch', None)
         try:
             collection = c.rhodecode_repo.get_changesets(start=0,
                                                     branch_name=branch_name)

rhodecode/controllers/followers.py

@@ -44,7 +44,7 b' class FollowersController(BaseRepoContro'
         super(FollowersController, self).__before__()
 
     def followers(self, repo_name):
-        p = safe_int(request.params.get('page', 1), 1)
+        p = safe_int(request.GET.get('page', 1), 1)
         repo_id = c.rhodecode_db_repo.repo_id
         d = UserFollowing.get_repo_followers(repo_id)\
             .order_by(UserFollowing.follows_from)

rhodecode/controllers/forks.py

@@ -110,7 +110,7 b' class ForksController(BaseRepoController'
     @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
                                    'repository.admin')
     def forks(self, repo_name):
-        p = safe_int(request.params.get('page', 1), 1)
+        p = safe_int(request.GET.get('page', 1), 1)
         repo_id = c.rhodecode_db_repo.repo_id
         d = []
         for r in Repository.get_repo_forks(repo_id):

rhodecode/controllers/journal.py

@@ -62,7 +62,7 b' class JournalController(BaseController):'
     @NotAnonymous()
     def index(self):
         # Return a rendered template
-        p = safe_int(request.params.get('page', 1), 1)
+        p = safe_int(request.GET.get('page', 1), 1)
         c.user = User.get(self.rhodecode_user.user_id)
         c.following = self.sa.query(UserFollowing)\
             .filter(UserFollowing.user_id == self.rhodecode_user.user_id)\
@@ -250,7 +250,7 b' class JournalController(BaseController):'
     @LoginRequired()
     def public_journal(self):
         # Return a rendered template
-        p = safe_int(request.params.get('page', 1), 1)
+        p = safe_int(request.GET.get('page', 1), 1)
 
         c.following = self.sa.query(UserFollowing)\
             .filter(UserFollowing.user_id == self.rhodecode_user.user_id)\

rhodecode/controllers/pullrequests.py

@@ -147,7 +147,7 b' class PullrequestsController(BaseRepoCon'
     def show_all(self, repo_name):
         c.pull_requests = PullRequestModel().get_all(repo_name)
         c.repo_name = repo_name
-        p = safe_int(request.params.get('page', 1), 1)
+        p = safe_int(request.GET.get('page', 1), 1)
 
         c.pullrequests_pager = Page(c.pull_requests, page=p, items_per_page=10)
 

rhodecode/controllers/search.py

@@ -84,7 +84,7 b' class SearchController(BaseRepoControlle'
             log.debug(cur_query)
 
         if c.cur_query:
-            p = safe_int(request.params.get('page', 1), 1)
+            p = safe_int(request.GET.get('page', 1), 1)
             highlight_items = set()
             try:
                 idx = open_dir(config['app_conf']['index_dir'],

rhodecode/controllers/shortlog.py

@@ -64,8 +64,8 b' class ShortlogController(BaseRepoControl'
             redirect(h.url('shortlog_home', repo_name=repo_name))
 
     def index(self, repo_name, revision=None, f_path=None):
-        p = safe_int(request.params.get('page', 1), 1)
-        size = safe_int(request.params.get('size', 20), 20)
+        p = safe_int(request.GET.get('page', 1), 1)
+        size = safe_int(request.GET.get('size', 20), 20)
         collection = c.rhodecode_repo
         c.file_history = f_path