js cleanup

rhodecode/templates/base/root.html

@@ -47,14 +47,18 b''
            ${self.js_extra()}
         
             <script type="text/javascript">
-            var base_url  = "${h.url('toggle_following')}";
-            function onSuccess(target){
+            var follow_base_url  = "${h.url('toggle_following')}";
+            var stop_follow_text = "${_('Stop following this repository')}";
+            var start_follow_text = "${_('Start following this repository')}"; 
+            
+            
+            var onSuccessFollow = function(target){
                 var f = YUD.get(target.id);
                 var f_cnt = YUD.get('current_followers_count');
                 
                 if(f.getAttribute('class')=='follow'){
                     f.setAttribute('class','following');
-                    f.setAttribute('title',"${_('Stop following this repository')}");
+                    f.setAttribute('title',stop_follow_text);
                     
                     if(f_cnt){
                         var cnt = Number(f_cnt.innerHTML)+1;
@@ -63,7 +67,7 b''
                 }
                 else{
                     f.setAttribute('class','follow');
-                    f.setAttribute('title',"${_('Start following this repository')}");
+                    f.setAttribute('title',start_follow_text);
                     if(f_cnt){
                         var cnt = Number(f_cnt.innerHTML)+1;
                         f_cnt.innerHTML = cnt;
@@ -71,37 +75,41 b''
                 }
             }
             
-            function toggleFollowingUser(target,fallows_user_id,token,user_id){
+            var toggleFollowingUser = function(target,fallows_user_id,token,user_id){
                 args = 'follows_user_id='+fallows_user_id;
                 args+= '&amp;auth_token='+token;
                 if(user_id != undefined){
                     args+="&amp;user_id="+user_id;
                 }
-                YUC.asyncRequest('POST',base_url,{
+                YUC.asyncRequest('POST',follow_base_url,{
                     success:function(o){
-                        onSuccess(target);
+                    	onSuccessFollow(target);
                     }
                 },args);
                 return false;
             }
             
-            function toggleFollowingRepo(target,fallows_repo_id,token,user_id){
+            var toggleFollowingRepo = function(target,fallows_repo_id,token,user_id){
             
                 args = 'follows_repo_id='+fallows_repo_id;
                 args+= '&amp;auth_token='+token;
                 if(user_id != undefined){
                     args+="&amp;user_id="+user_id;
                 }    
-                YUC.asyncRequest('POST',base_url,{
+                YUC.asyncRequest('POST',follow_base_url,{
                     success:function(o){
-                        onSuccess(target);
+                    	onSuccessFollow(target);
                     }
                 },args); 
                 return false;
             }
            YUE.onDOMReady(function(){
-               
+             tooltip_activate();
+             show_more_event();               
+             
              YUE.on('quick_login_link','click',function(e){
+                 // make sure we don't redirect 
+                 YUE.preventDefault(e);
                  
                  if(YUD.hasClass('quick_login_link','enabled')){
                      YUD.setStyle('quick_login','display','none');
@@ -112,13 +120,8 b''
                      YUD.addClass('quick_login_link','enabled');
                      YUD.get('username').focus();
                  }
-                 //make sure we don't redirect 
-                 YUE.preventDefault(e);
              });
-               
-            tooltip_activate();
-            show_more_event();
-            
+             
             YUE.on(YUQ('.quick_repo_menu'),'click',function(e){
             	var menu = e.currentTarget.firstElementChild;
             	if(YUD.hasClass(menu,'hidden')){
@@ -129,6 +132,7 b''
             		YUD.addClass(menu,'hidden');
             	}
             })
+            
             YUE.on(window,'scroll',function(){
                 if(YUD.getDocumentScrollTop() > 45){
                       YUD.addClass('header-inner','hover');
@@ -140,8 +144,7 b''
            })   
             </script>
         </%def>
-        <%def name="js_extra()">
-        </%def>      
+        <%def name="js_extra()"></%def>
         ${self.js()}
     </head>
     <body id="body">