get stderr also for git commands, pass in shell = False

rhodecode/lib/subprocessio.py

@@ -341,9 +341,10 b' class SubprocessIOChunker(object):'
         if isinstance(cmd, (list, tuple)):
             cmd = ' '.join(cmd)
 
+        _shell = kwargs.get('shell') or True
+        kwargs['shell'] = _shell
         _p = subprocess.Popen(cmd,
             bufsize=-1,
-            shell=True,
             stdin=inputstream,
             stdout=subprocess.PIPE,
             stderr=subprocess.PIPE,

rhodecode/lib/vcs/backends/git/repository.py

@@ -115,6 +115,7 b' class GitRepository(BaseRepository):'
         try:
             opts = dict(
                 env=gitenv,
+                shell=False,
             )
             if os.path.isdir(self.path):
                 opts['cwd'] = self.path
@@ -124,9 +125,7 b' class GitRepository(BaseRepository):'
             raise RepositoryError("Couldn't run git command (%s).\n"
                                   "Original error was:%s" % (cmd, err))
 
-        so = ''.join(p)
-        se = None
-        return so, se
+        return ''.join(p.output), ''.join(p.error)
 
     @classmethod
     def _check_url(cls, url):