##// END OF EJS Templates
phabricator: warn if unable to amend, instead of aborting after posting...
phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

File last commit:

r34447:b0c97e44 default
r41198:0101a35d default
Show More
test-revlog-mmapindex.t
56 lines | 1.1 KiB | text/troff | Tads3Lexer
/ tests / test-revlog-mmapindex.t
Mark Thomas
revlog: add option to mmap revlog index...
r34297 create verbosemmap.py
$ cat << EOF > verbosemmap.py
> # extension to make util.mmapread verbose
>
> from __future__ import absolute_import
>
> from mercurial import (
> extensions,
Pulkit Goyal
py3: pass bytes from extension to ui.write() in test-revlog-mmapindex.t...
r35405 > pycompat,
Mark Thomas
revlog: add option to mmap revlog index...
r34297 > util,
> )
>
Jun Wu
test-revlog-mmapindex: make it compatible with chg...
r34447 > def extsetup(ui):
> def mmapread(orig, fp):
Pulkit Goyal
py3: pass bytes from extension to ui.write() in test-revlog-mmapindex.t...
r35405 > ui.write(b"mmapping %s\n" % pycompat.bytestr(fp.name))
Jun Wu
test-revlog-mmapindex: make it compatible with chg...
r34447 > ui.flush()
> return orig(fp)
Mark Thomas
revlog: add option to mmap revlog index...
r34297 >
> extensions.wrapfunction(util, 'mmapread', mmapread)
> EOF
setting up base repo
$ hg init a
$ cd a
$ touch a
$ hg add a
$ hg commit -qm base
$ for i in `$TESTDIR/seq.py 1 100` ; do
> echo $i > a
> hg commit -qm $i
> done
set up verbosemmap extension
$ cat << EOF >> $HGRCPATH
> [extensions]
> verbosemmap=$TESTTMP/verbosemmap.py
> EOF
mmap index which is now more than 4k long
$ hg log -l 5 -T '{rev}\n' --config experimental.mmapindexthreshold=4k
Matt Harbison
tests: remove (glob) annotations that were only for '\' matches...
r35394 mmapping $TESTTMP/a/.hg/store/00changelog.i
Mark Thomas
revlog: add option to mmap revlog index...
r34297 100
99
98
97
96
do not mmap index which is still less than 32k
$ hg log -l 5 -T '{rev}\n' --config experimental.mmapindexthreshold=32k
100
99
98
97
96
$ cd ..