upstream/mercurial-mirror Files · tests/test-revlog-mmapindex.t

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Jun Wu - - Load All Authors

File last commit:

r34447:b0c97e44 default


                r41198:0101a35d

default

Download file

             test-revlog-mmapindex.t
        
                    56 lines
            
             | 1.1 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-revlog-mmapindex.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      create verbosemmap.py

        $ cat << EOF > verbosemmap.py

        > # extension to make util.mmapread verbose

        > 

        > from __future__ import absolute_import

        > 

        > from mercurial import (

        >     extensions,

        >     pycompat,

        >     util,

        > )

        > 

        > def extsetup(ui):

        >     def mmapread(orig, fp):

        >         ui.write(b"mmapping %s\n" % pycompat.bytestr(fp.name))

        >         ui.flush()

        >         return orig(fp)

        > 

        >     extensions.wrapfunction(util, 'mmapread', mmapread)

        > EOF

      setting up base repo

        $ hg init a

        $ cd a

        $ touch a

        $ hg add a

        $ hg commit -qm base

        $ for i in `$TESTDIR/seq.py 1 100` ; do

        > echo $i > a

        > hg commit -qm $i

        > done

      set up verbosemmap extension

        $ cat << EOF >> $HGRCPATH

        > [extensions]

        > verbosemmap=$TESTTMP/verbosemmap.py

        > EOF

      mmap index which is now more than 4k long

        $ hg log -l 5 -T '{rev}\n' --config experimental.mmapindexthreshold=4k

        mmapping $TESTTMP/a/.hg/store/00changelog.i

        100

        99

        98

        97

        96

      do not mmap index which is still less than 32k

        $ hg log -l 5 -T '{rev}\n' --config experimental.mmapindexthreshold=32k

        100

        99

        98

        97

        96

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				create verbosemmap.py
				$ cat << EOF > verbosemmap.py
				> # extension to make util.mmapread verbose
				>
				> from __future__ import absolute_import
				>
				> from mercurial import (
				> extensions,
				> pycompat,
				> util,
				> )
				>
				> def extsetup(ui):
				> def mmapread(orig, fp):
				> ui.write(b"mmapping %s\n" % pycompat.bytestr(fp.name))
				> ui.flush()
				> return orig(fp)
				>
				> extensions.wrapfunction(util, 'mmapread', mmapread)
				> EOF

				setting up base repo
				$ hg init a
				$ cd a
				$ touch a
				$ hg add a
				$ hg commit -qm base
				$ for i in `$TESTDIR/seq.py 1 100` ; do
				> echo $i > a
				> hg commit -qm $i
				> done

				set up verbosemmap extension
				$ cat << EOF >> $HGRCPATH
				> [extensions]
				> verbosemmap=$TESTTMP/verbosemmap.py
				> EOF

				mmap index which is now more than 4k long
				$ hg log -l 5 -T '{rev}\n' --config experimental.mmapindexthreshold=4k
				mmapping $TESTTMP/a/.hg/store/00changelog.i
				100
				99
				98
				97
				96

				do not mmap index which is still less than 32k
				$ hg log -l 5 -T '{rev}\n' --config experimental.mmapindexthreshold=32k
				100
				99
				98
				97
				96

				$ cd ..