##// END OF EJS Templates
phabricator: warn if unable to amend, instead of aborting after posting...
phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

File last commit:

r37803:b4d85bc1 default
r41198:0101a35d default
Show More
test-sshserver.py
53 lines | 1.5 KiB | text/x-python | PythonLexer
/ tests / test-sshserver.py
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770 from __future__ import absolute_import, print_function
import io
import unittest
import silenttestrunner
from mercurial import (
Gregory Szorc
wireprotoserver: move sshserver into module (API)...
r35877 wireprotoserver,
Gregory Szorc
wireproto: rename wireproto to wireprotov1server (API)...
r37803 wireprotov1server,
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770 )
Yuya Nishihara
procutil: bulk-replace function calls to point to new module
r37138 from mercurial.utils import (
procutil,
)
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770 class SSHServerGetArgsTests(unittest.TestCase):
def testparseknown(self):
tests = [
Gregory Szorc
py3: add b'' to test-sshserver.py...
r36230 (b'* 0\nnodes 0\n', [b'', {}]),
(b'* 0\nnodes 40\n1111111111111111111111111111111111111111\n',
[b'1111111111111111111111111111111111111111', {}]),
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770 ]
for input, expected in tests:
Gregory Szorc
py3: add b'' to test-sshserver.py...
r36230 self.assertparse(b'known', input, expected)
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770
def assertparse(self, cmd, input, expected):
server = mockserver(input)
Gregory Szorc
wireprotoserver: move SSH server operation to a standalone function...
r36232 proto = wireprotoserver.sshv1protocolhandler(server._ui,
server._fin,
server._fout)
Gregory Szorc
wireproto: rename wireproto to wireprotov1server (API)...
r37803 _func, spec = wireprotov1server.commands[cmd]
Gregory Szorc
wireprotoserver: move SSH server operation to a standalone function...
r36232 self.assertEqual(proto.getargs(spec), expected)
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770
def mockserver(inbytes):
ui = mockui(inbytes)
repo = mockrepo(ui)
Gregory Szorc
wireprotoserver: move sshserver into module (API)...
r35877 return wireprotoserver.sshserver(ui, repo)
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770
class mockrepo(object):
def __init__(self, ui):
self.ui = ui
class mockui(object):
def __init__(self, inbytes):
self.fin = io.BytesIO(inbytes)
self.fout = io.BytesIO()
self.ferr = io.BytesIO()
if __name__ == '__main__':
Matt Harbison
test-sshserver: stabilize for Windows
r35790 # Don't call into msvcrt to set BytesIO to binary mode
Yuya Nishihara
procutil: bulk-replace function calls to point to new module
r37138 procutil.setbinary = lambda fp: True
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770 silenttestrunner.main(__name__)