upstream/mercurial-mirror Files · tests/test-sshserver.py

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Gregory Szorc - - Load All Authors

File last commit:

r37803:b4d85bc1 default


                r41198:0101a35d

default

Download file

             test-sshserver.py
        
                    53 lines
            
             | 1.5 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / test-sshserver.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      from __future__ import absolute_import, print_function

      import io

      import unittest

      import silenttestrunner

      from mercurial import (

          wireprotoserver,

          wireprotov1server,

      )

      from mercurial.utils import (

          procutil,

      )

      class SSHServerGetArgsTests(unittest.TestCase):

          def testparseknown(self):

              tests = [

                  (b'* 0\nnodes 0\n', [b'', {}]),

                  (b'* 0\nnodes 40\n1111111111111111111111111111111111111111\n',

                   [b'1111111111111111111111111111111111111111', {}]),

              ]

              for input, expected in tests:

                  self.assertparse(b'known', input, expected)

          def assertparse(self, cmd, input, expected):

              server = mockserver(input)

              proto = wireprotoserver.sshv1protocolhandler(server._ui,

                                                           server._fin,

                                                           server._fout)

              _func, spec = wireprotov1server.commands[cmd]

              self.assertEqual(proto.getargs(spec), expected)

      def mockserver(inbytes):

          ui = mockui(inbytes)

          repo = mockrepo(ui)

          return wireprotoserver.sshserver(ui, repo)

      class mockrepo(object):

          def __init__(self, ui):

              self.ui = ui

      class mockui(object):

          def __init__(self, inbytes):

              self.fin = io.BytesIO(inbytes)

              self.fout = io.BytesIO()

              self.ferr = io.BytesIO()

      if __name__ == '__main__':

          # Don't call into msvcrt to set BytesIO to binary mode

          procutil.setbinary = lambda fp: True

          silenttestrunner.main(__name__)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				from __future__ import absolute_import, print_function

				import io
				import unittest

				import silenttestrunner

				from mercurial import (
				wireprotoserver,
				wireprotov1server,
				)

				from mercurial.utils import (
				procutil,
				)

				class SSHServerGetArgsTests(unittest.TestCase):
				def testparseknown(self):
				tests = [
				(b'* 0\nnodes 0\n', [b'', {}]),
				(b'* 0\nnodes 40\n1111111111111111111111111111111111111111\n',
				[b'1111111111111111111111111111111111111111', {}]),
				]
				for input, expected in tests:
				self.assertparse(b'known', input, expected)

				def assertparse(self, cmd, input, expected):
				server = mockserver(input)
				proto = wireprotoserver.sshv1protocolhandler(server._ui,
				server._fin,
				server._fout)
				_func, spec = wireprotov1server.commands[cmd]
				self.assertEqual(proto.getargs(spec), expected)

				def mockserver(inbytes):
				ui = mockui(inbytes)
				repo = mockrepo(ui)
				return wireprotoserver.sshserver(ui, repo)

				class mockrepo(object):
				def __init__(self, ui):
				self.ui = ui

				class mockui(object):
				def __init__(self, inbytes):
				self.fin = io.BytesIO(inbytes)
				self.fout = io.BytesIO()
				self.ferr = io.BytesIO()

				if __name__ == '__main__':
				# Don't call into msvcrt to set BytesIO to binary mode
				procutil.setbinary = lambda fp: True
				silenttestrunner.main(__name__)