##// END OF EJS Templates
phabricator: warn if unable to amend, instead of aborting after posting...
phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

File last commit:

r37961:32bc3815 default
r41198:0101a35d default
Show More
test-ui-color.py
40 lines | 1023 B | text/x-python | PythonLexer
Pulkit Goyal
tests: make test-ui-color use absolute_import
r28915 from __future__ import absolute_import, print_function
Simon Heimberg
cleanup: remove unused imports...
r19322 import os
Pulkit Goyal
tests: make test-ui-color use absolute_import
r28915 from mercurial import (
dispatch,
ui as uimod,
)
Augie Fackler
tests: port test-ui-color.py to Python 3...
r37944 from mercurial.utils import (
stringutil,
)
Brodie Rao
color: call correct superclass method in write_err...
r11732
# ensure errors aren't buffered
Pierre-Yves David
color: drop the 'colorui' class...
r31095 testui = uimod.ui()
Brodie Rao
color: call correct superclass method in write_err...
r11732 testui.pushbuffer()
Pulkit Goyal
py3: add b'' to test-ui-color.py...
r36354 testui.write((b'buffered\n'))
testui.warn((b'warning\n'))
testui.write_err(b'error\n')
Yuya Nishihara
stringutil: flip the default of pprint() to bprefix=False...
r37961 print(stringutil.pprint(testui.popbuffer(), bprefix=True).decode('ascii'))
Idan Kamara
color: check if ui is already a subclass of colorui before wrapping it...
r14516
# test dispatch.dispatch with the same ui object
Pulkit Goyal
py3: make sure we open file in bytes mode...
r36355 hgrc = open(os.environ["HGRCPATH"], 'wb')
Pulkit Goyal
py3: add b'' to test-ui-color.py...
r36354 hgrc.write(b'[extensions]\n')
hgrc.write(b'color=\n')
Idan Kamara
color: check if ui is already a subclass of colorui before wrapping it...
r14516 hgrc.close()
Yuya Nishihara
ui: factor out ui.load() to create a ui without loading configs (API)...
r30559 ui_ = uimod.ui.load()
Pulkit Goyal
py3: add b'' to test-ui-color.py...
r36354 ui_.setconfig(b'ui', b'formatted', b'True')
Idan Kamara
color: check if ui is already a subclass of colorui before wrapping it...
r14516
Idan Kamara
ui: use I/O descriptors internally...
r14614 # we're not interested in the output, so write that to devnull
Pulkit Goyal
py3: make sure we open file in bytes mode...
r36355 ui_.fout = open(os.devnull, 'wb')
Idan Kamara
ui: use I/O descriptors internally...
r14614
Idan Kamara
color: check if ui is already a subclass of colorui before wrapping it...
r14516 # call some arbitrary command just so we go through
# color's wrapped _runcommand twice.
def runcmd():
Pulkit Goyal
py3: add b'' to test-ui-color.py...
r36354 dispatch.dispatch(dispatch.request([b'version', b'-q'], ui_))
Idan Kamara
color: check if ui is already a subclass of colorui before wrapping it...
r14516
runcmd()
Pierre-Yves David
color: drop the 'colorui' class...
r31095 print("colored? %s" % (ui_._colormode is not None))
Idan Kamara
color: check if ui is already a subclass of colorui before wrapping it...
r14516 runcmd()
Pierre-Yves David
color: drop the 'colorui' class...
r31095 print("colored? %s" % (ui_._colormode is not None))