upstream/mercurial-mirror Files · tests/test-ui-color.py

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Yuya Nishihara - - Load All Authors

File last commit:

r37961:32bc3815 default


                r41198:0101a35d

default

Download file

             test-ui-color.py
        
                    40 lines
            
             | 1023 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / test-ui-color.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      from __future__ import absolute_import, print_function

      import os

      from mercurial import (

          dispatch,

          ui as uimod,

      )

      from mercurial.utils import (

          stringutil,

      )

      # ensure errors aren't buffered

      testui = uimod.ui()

      testui.pushbuffer()

      testui.write((b'buffered\n'))

      testui.warn((b'warning\n'))

      testui.write_err(b'error\n')

      print(stringutil.pprint(testui.popbuffer(), bprefix=True).decode('ascii'))

      # test dispatch.dispatch with the same ui object

      hgrc = open(os.environ["HGRCPATH"], 'wb')

      hgrc.write(b'[extensions]\n')

      hgrc.write(b'color=\n')

      hgrc.close()

      ui_ = uimod.ui.load()

      ui_.setconfig(b'ui', b'formatted', b'True')

      # we're not interested in the output, so write that to devnull

      ui_.fout = open(os.devnull, 'wb')

      # call some arbitrary command just so we go through

      # color's wrapped _runcommand twice.

      def runcmd():

          dispatch.dispatch(dispatch.request([b'version', b'-q'], ui_))

      runcmd()

      print("colored? %s" % (ui_._colormode is not None))

      runcmd()

      print("colored? %s" % (ui_._colormode is not None))

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				from __future__ import absolute_import, print_function

				import os
				from mercurial import (
				dispatch,
				ui as uimod,
				)
				from mercurial.utils import (
				stringutil,
				)

				# ensure errors aren't buffered
				testui = uimod.ui()
				testui.pushbuffer()
				testui.write((b'buffered\n'))
				testui.warn((b'warning\n'))
				testui.write_err(b'error\n')
				print(stringutil.pprint(testui.popbuffer(), bprefix=True).decode('ascii'))

				# test dispatch.dispatch with the same ui object
				hgrc = open(os.environ["HGRCPATH"], 'wb')
				hgrc.write(b'[extensions]\n')
				hgrc.write(b'color=\n')
				hgrc.close()

				ui_ = uimod.ui.load()
				ui_.setconfig(b'ui', b'formatted', b'True')

				# we're not interested in the output, so write that to devnull
				ui_.fout = open(os.devnull, 'wb')

				# call some arbitrary command just so we go through
				# color's wrapped _runcommand twice.
				def runcmd():
				dispatch.dispatch(dispatch.request([b'version', b'-q'], ui_))

				runcmd()
				print("colored? %s" % (ui_._colormode is not None))
				runcmd()
				print("colored? %s" % (ui_._colormode is not None))