##// END OF EJS Templates
cmdutil: add class to restore dirstate during unexpected failure...
cmdutil: add class to restore dirstate during unexpected failure Before this patch, after "dirstate.write()" execution, there was no way to restore dirstate to the original status before "dirstate.write()". In some code paths, "dirstate.invalidate()" is used as a kind of "restore .hg/dirstate to the original status", but it just avoids writing changes in memory out, and doesn't actually restore the ".hg/dirstate" file. To fix the issue that the recent (in memory) dirstate isn't visible to external processes (e.g. "precommit" hooks), "dirstate.write()" should be invoked before invocation of external processes. But at the same time, ".hg/dirstate" should be restored to its content before "dirstate.write()" during an unexpected failure in some cases. This patch adds the class "dirstateguard" to easily restore ".hg/dirstate" during unexpected failures. Typical usecase of it is: # (1) build dirstate up .... # (2) write dirstate out, and backup ".hg/dirstate" dsguard = dirstateguard(repo, 'scopename') try: # (3) execute somethig to do: # this may imply making some additional changes on dirstate .... # (4) unlink backed-up dirstate file at the end of dsguard scope dsguard.close() finally: # (5) if execution is aborted before "dsguard.close()", # ".hg/dirstate" is restored from the backup dsguard.release() For this kind of issue, an "extending transaction" approach (in https://titanpad.com/mercurial32-sprint) seems to not be suitable, because: - transaction nesting occurs in some cases (e.g. "shelve => rebase"), and - "dirstate" may be already modified since the beginning of OUTER transaction scope, then - dirstate should be backed up into the file other than "dirstate.journal" at the beginning of INNER transaction scope, but - such alternative backup files are useless for transaction itself, and increases complication of its implementation "transaction" and "dirstateguard" differ from each other also in "what it should do for .hg/dirstate" in cases other than success. ============== ======= ======== ============= type success fail "hg rollback" ============== ======= ======== ============= transaction keep keep restore dirstateguard keep restore (not implied) ============== ======= ======== ============= Some collaboration between transaction and dirstate will probably be introduced in the future. But this layer is needed in all cases.

File last commit:

r24217:d2b81256 default
r24991:4169a4f8 default
Show More
error.py
166 lines | 5.0 KiB | text/x-python | PythonLexer
Martin Geisler
put license and copyright info into comment blocks
r8226 # error.py - Mercurial exceptions
#
# Copyright 2005-2008 Matt Mackall <mpm@selenic.com>
#
# This software may be used and distributed according to the terms of the
Matt Mackall
Update license to GPLv2+
r10263 # GNU General Public License version 2 or any later version.
Matt Mackall
errors: move revlog errors...
r7633
Martin Geisler
turn some comments back into module docstrings
r8227 """Mercurial exceptions.
This allows us to catch exceptions at higher levels without forcing
imports.
"""
Matt Mackall
errors: move revlog errors...
r7633 # Do not import anything here, please
class RevlogError(Exception):
pass
Pierre-Yves David
repoview: add a FilteredIndexError class...
r23014 class FilteredIndexError(IndexError):
pass
Matt Mackall
errors: move revlog errors...
r7633 class LookupError(RevlogError, KeyError):
def __init__(self, name, index, message):
self.name = name
Martin von Zweigbergk
error: store filename and message on LookupError for later...
r24038 self.index = index
Siddharth Agarwal
error.LookupError: rename 'message' property to something else...
r24137 # this can't be called 'message' because at least some installs of
# Python 2.6+ complain about the 'message' property being deprecated
self.lookupmessage = message
Matt Mackall
errors: move revlog errors...
r7633 if isinstance(name, str) and len(name) == 20:
from node import short
name = short(name)
RevlogError.__init__(self, '%s@%s: %s' % (index, name, message))
def __str__(self):
return RevlogError.__str__(self)
Matt Mackall
error: move ParseError
r7636
Pierre-Yves David
repoview: add a FilteredLookupError class...
r23015 class FilteredLookupError(LookupError):
pass
Takumi IINO
hgweb: show correct error message for i18n environment...
r18855 class ManifestLookupError(LookupError):
pass
Matt Mackall
error: change ParseError to CommandError
r11287 class CommandError(Exception):
Matt Mackall
error: move ParseError
r7636 """Exception raised on errors in parsing the command line."""
Matt Mackall
error: move repo errors...
r7637
Augie Fackler
error: introduce new InterventionRequired exception...
r18931 class InterventionRequired(Exception):
"""Exception raised when a command requires human intervention."""
Matt Mackall
error: add new ParseError for various parsing errors
r11288 class Abort(Exception):
"""Raised if a command needs to print an error and exit."""
Benoit Boissinot
Abort: add a hint argument, printed in the next line inside parenthesis...
r11574 def __init__(self, *args, **kw):
Exception.__init__(self, *args)
self.hint = kw.get('hint')
Matt Mackall
error: add new ParseError for various parsing errors
r11288
Pierre-Yves David
hook: raise a more specialized HookAbort exception when a hook fails...
r23415 class HookAbort(Abort):
"""raised when a validation hook fails, aborting an operation
Exists to allow more specialized catching."""
pass
Matt Mackall
error: add new ParseError for various parsing errors
r11288 class ConfigError(Abort):
Mike Edgar
error: use docstrings, not bare strings, for error classes
r22359 """Exception raised when parsing config files"""
Matt Mackall
ui: introduce new config parser
r8144
Andrew Pritchard
wireproto: add out-of-band error class to allow remote repo to report errors...
r15017 class OutOfBandError(Exception):
Mike Edgar
error: use docstrings, not bare strings, for error classes
r22359 """Exception raised when a remote repo reports failure"""
Andrew Pritchard
wireproto: add out-of-band error class to allow remote repo to report errors...
r15017
Matt Mackall
error: fix up test-hgrc
r11292 class ParseError(Exception):
Augie Fackler
error: update docstring on ParseError...
r24040 """Raised when parsing config files and {rev,file}sets (msg[, pos])"""
Matt Mackall
error: add new ParseError for various parsing errors
r11288
Augie Fackler
error: add a new UnknownIdentifier error type...
r24217 class UnknownIdentifier(ParseError):
"""Exception raised when a {rev,file}set references an unknown identifier"""
def __init__(self, function, symbols):
from i18n import _
ParseError.__init__(self, _("unknown identifier: %s") % function)
self.function = function
self.symbols = symbols
Matt Mackall
error: move repo errors...
r7637 class RepoError(Exception):
Pierre-Yves David
error: Add a hint argument to RepoError...
r14761 def __init__(self, *args, **kw):
Exception.__init__(self, *args)
self.hint = kw.get('hint')
Matt Mackall
error: move repo errors...
r7637
Matt Mackall
Make distinct lookup error for localrepo.lookup...
r9423 class RepoLookupError(RepoError):
pass
Pierre-Yves David
repoview: add a FilteredRepoLookupError...
r23016 class FilteredRepoLookupError(RepoLookupError):
pass
Matt Mackall
error: move repo errors...
r7637 class CapabilityError(RepoError):
pass
Matt Mackall
error: move lock errors...
r7640
Adrian Buehlmann
introduce new RequirementError (issue2649)...
r13447 class RequirementError(RepoError):
"""Exception raised if .hg/requires has an unknown entry."""
pass
Matt Mackall
error: move lock errors...
r7640 class LockError(IOError):
def __init__(self, errno, strerror, filename, desc):
IOError.__init__(self, errno, strerror, filename)
self.desc = desc
class LockHeld(LockError):
def __init__(self, errno, filename, desc, locker):
LockError.__init__(self, errno, 'Lock held', filename, desc)
self.locker = locker
class LockUnavailable(LockError):
pass
Matt Mackall
error: move UnexpectedOutput (now ResponseError)
r7641
class ResponseError(Exception):
"""Raised to print an error with part of output and exit."""
Matt Mackall
error: move UnknownCommand and AmbiguousCommand
r7643 class UnknownCommand(Exception):
"""Exception raised if command is not in the command table."""
class AmbiguousCommand(Exception):
"""Exception raised if command shortcut matches more than one command."""
Matt Mackall
error: move SignalInterrupt...
r7644 # derived from KeyboardInterrupt to simplify some breakout code
class SignalInterrupt(KeyboardInterrupt):
"""Exception raised on SIGTERM and SIGHUP."""
Matt Mackall
error: move SignatureError
r7646
class SignatureError(Exception):
pass
Pierre-Yves David
bundle2: fix raising errors during heads checking...
r21184
class PushRaced(RuntimeError):
"""An exception raised during unbundling that indicate a push race"""
Pierre-Yves David
bundle2: move exception classes into the error module...
r21618 # bundle2 related errors
class BundleValueError(ValueError):
Pierre-Yves David
bundle2: introduce a ``params`` attribute to BundleValueError...
r21621 """error raised when bundle2 cannot be processed"""
Pierre-Yves David
bundle2: introduce a parttype attribute to BundleValueError...
r21620
Pierre-Yves David
bundle2: add an UnsupportedPartError...
r23010 class UnsupportedPartError(BundleValueError):
Pierre-Yves David
bundle2: support None parttype in BundleValueError...
r21627 def __init__(self, parttype=None, params=()):
Pierre-Yves David
bundle2: introduce a parttype attribute to BundleValueError...
r21620 self.parttype = parttype
Pierre-Yves David
bundle2: introduce a ``params`` attribute to BundleValueError...
r21621 self.params = params
Pierre-Yves David
bundle2: support None parttype in BundleValueError...
r21627 if self.parttype is None:
msg = 'Stream Parameter'
else:
msg = parttype
Pierre-Yves David
bundle2: introduce a ``params`` attribute to BundleValueError...
r21621 if self.params:
msg = '%s - %s' % (msg, ', '.join(self.params))
Brendan Cully
error: restore python 2.4 compatibility for BundleValueError...
r21747 ValueError.__init__(self, msg)
Pierre-Yves David
bundle2: move exception classes into the error module...
r21618
class ReadOnlyPartError(RuntimeError):
"""error raised when code tries to alter a part being generated"""
pass
Mike Edgar
error: add CensoredNodeError, will be thrown when content deliberately erased...
r22595 class CensoredNodeError(RevlogError):
Mike Edgar
changegroup: emit full-replacement deltas if either revision is censored...
r24190 """error raised when content verification fails on a censored node
Mike Edgar
error: add CensoredNodeError, will be thrown when content deliberately erased...
r22595
Mike Edgar
changegroup: emit full-replacement deltas if either revision is censored...
r24190 Also contains the tombstone data substituted for the uncensored data.
"""
def __init__(self, filename, node, tombstone):
Mike Edgar
error: add CensoredNodeError, will be thrown when content deliberately erased...
r22595 from node import short
RevlogError.__init__(self, '%s:%s' % (filename, short(node)))
Mike Edgar
changegroup: emit full-replacement deltas if either revision is censored...
r24190 self.tombstone = tombstone
Mike Edgar
revlog: in addgroup, reject ill-formed deltas based on censored nodes...
r24120
class CensoredBaseError(RevlogError):
"""error raised when a delta is rejected because its base is censored
A delta based on a censored revision must be formed as single patch
operation which replaces the entire base with new content. This ensures
the delta may be applied by clones which have not censored the base.
"""