upstream/mercurial-mirror Files · tests/test-check-pylint.t

wireprotov2: define and implement "manifestdata" command...

wireprotov2: define and implement "manifestdata" command The added command can be used for obtaining manifest data. Given a manifest path and set of manifest nodes, data about manifests can be retrieved. Unlike changeset data, we wish to emit deltas to describe manifest revisions. So the command uses the relatively new API for building delta requests and emitting them. The code calls into deltaparent(), which I'm not very keen of. There's still work to be done in delta generation land so implementation details of storage (e.g. exactly one delta is stored/available) don't creep into higher levels. But we can worry about this later (there is already a TODO on imanifestorage tracking this). On the subject of parent deltas, the server assumes parent revisions exist on the receiving end. This is obviously wrong for shallow clone. I've added TODOs to add a mechanism to the command to allow clients to specify desired behavior. This shouldn't be too difficult to implement. Another big change is that the client must explicitly request manifest nodes to retrieve. This is a major departure from "getbundle," where the server derives relevant manifests as it iterates changesets and sends them automatically. As implemented, the client must transmit each requested node to the server. At 20 bytes per node, we're looking at 2 MB per 100,000 nodes. Plus wire encoding overhead. This isn't ideal for clients with limited upload bandwidth. I plan to address this in the future by allowing alternate mechanisms for defining the revisions to retrieve. One idea is to define a range of changeset revisions whose manifest revisions to retrieve (similar to how "changesetdata" works). We almost certainly want an API to look up an individual manifest by node. And that's where I've chosen to start with the implementation. Again, a theme of this early exchangev2 work is I want to start by building primitives for accessing raw repository data first and see how far we can get with those before we need more complexity. Differential Revision: https://phab.mercurial-scm.org/D4488

Matt Harbison - - Load All Authors

File last commit:

r38206:6ae62d62 stable


                r39673:c7a7c7e8

default

Download file

             test-check-pylint.t
        
                    22 lines
            
             | 616 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-check-pylint.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Pierre-Yves David
    
test: add a basic 'test-check-pylint.t'...

              r31413
            
      #require test-repo pylint hg10

      Run pylint for known rules we care about.

      -----------------------------------------

      There should be no recorded failures; fix the codebase before introducing a

      new check.

      Current checks:

      - W0102: no mutable default argument

        $ touch $TESTTMP/fakerc

        $ pylint --rcfile=$TESTTMP/fakerc --disable=all \

        Boris Feld
    
pylint: add a check for multiple statement on a single line...

              r35648
            
        >   --enable=W0102,C0321 \

        Boris Feld
    
pylint: split command line argument on multiple lines...

              r35645
            
        >   --reports=no \

        Siddharth Agarwal
    
tests: disable lints on mercurial/thirdparty...

              r34396
            
        >   --ignore=thirdparty \

        Matt Harbison
    
tests: adapt test-check-pylint to run on Windows...

              r38206
            
        >   mercurial hgdemandimport hgext hgext3rd | sed 's/\r$//'

        Using config file *fakerc (glob) (?)

        Jun Wu
    
test-check-pylint: match its output...

              r31839
            
         (?)

        ------------------------------------ (?)

        Your code has been rated at 10.00/10 (?)

         (?)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Pierre-Yves David test: add a basic 'test-check-pylint.t'...	r31413	#require test-repo pylint hg10

		Run pylint for known rules we care about.
		-----------------------------------------

		There should be no recorded failures; fix the codebase before introducing a
		new check.

		Current checks:
		- W0102: no mutable default argument

		$ touch $TESTTMP/fakerc
		$ pylint --rcfile=$TESTTMP/fakerc --disable=all \
Boris Feld pylint: add a check for multiple statement on a single line...	r35648	> --enable=W0102,C0321 \
Boris Feld pylint: split command line argument on multiple lines...	r35645	> --reports=no \
Siddharth Agarwal tests: disable lints on mercurial/thirdparty...	r34396	> --ignore=thirdparty \
Matt Harbison tests: adapt test-check-pylint to run on Windows...	r38206	> mercurial hgdemandimport hgext hgext3rd \| sed 's/\r$//'
		Using config file *fakerc (glob) (?)
Jun Wu test-check-pylint: match its output...	r31839	(?)
		------------------------------------ (?)
		Your code has been rated at 10.00/10 (?)
		(?)