##// END OF EJS Templates
bdiff: improve worst case behavior by 100x....
bdiff: improve worst case behavior by 100x. on 5.8MB (244.000 lines) text file with similar lines, hash before this change made diff against empty file take 75 seconds. this change improves performance to 0.6 seconds. result is that clone of smallish repo (137MB) with some files like this takes 1 minute instead of 10 minutes. common case of diff is 10% slower now, probably because of worse cache locality. but diff does not affect overall performance in common case (less than 1% of runtime is in diff when it is working ok), so this tradeoff looks good.

File last commit:

r2543:860e9c83 default
r2577:fa76c5d6 default
Show More
mpatch.c
408 lines | 8.4 KiB | text/x-c | CLexer
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 /*
mpatch.c - efficient binary patching for Mercurial
This implements a patch algorithm that's O(m + nlog n) where m is the
size of the output and n is the number of patches.
Given a list of binary patches, it unpacks each into a hunk list,
then combines the hunk lists with a treewise recursion to form a
single hunk list. This hunk list is then applied to the original
text.
The text (or binary) fragments are copied directly from their source
Python objects into a preallocated output string to avoid the
allocation of intermediate Python objects. Working memory is about 2x
the total number of hunks.
Copyright 2005 Matt Mackall <mpm@selenic.com>
This software may be used and distributed according to the terms
of the GNU General Public License, incorporated herein by reference.
*/
#include <Python.h>
#include <stdlib.h>
#include <string.h>
Vadim Gelfer
mac os x: fixes for 10.2 from chris monson <monpublic@gmail.com>
r2468
mpm@selenic.com
Make mpatch.c compilable under the other `OS'...
r410 #ifdef _WIN32
Vadim Gelfer
mac os x: fixes for 10.2 from chris monson <monpublic@gmail.com>
r2468 # ifdef _MSC_VER
/* msvc 6.0 has problems */
# define inline __inline
mpm@selenic.com
[PATCH] bdiff/mpatch under MSVC...
r551 typedef unsigned long uint32_t;
Vadim Gelfer
mac os x: fixes for 10.2 from chris monson <monpublic@gmail.com>
r2468 # else
# include <stdint.h>
# endif
mpm@selenic.com
Add 'other OS' bits to bdiff.c / style cleanups...
r411 static uint32_t ntohl(uint32_t x)
{
return ((x & 0x000000ffUL) << 24) |
((x & 0x0000ff00UL) << 8) |
((x & 0x00ff0000UL) >> 8) |
((x & 0xff000000UL) >> 24);
mpm@selenic.com
Make mpatch.c compilable under the other `OS'...
r410 }
#else
Vadim Gelfer
mac os x: fixes for 10.2 from chris monson <monpublic@gmail.com>
r2468 /* not windows */
# include <sys/types.h>
# include <arpa/inet.h>
Thomas Arendsen Hein
Include inttypes.h instead of stdint.h (fixes issue299)...
r2543 # include <inttypes.h>
mpm@selenic.com
Make mpatch.c compilable under the other `OS'...
r410 #endif
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
static char mpatch_doc[] = "Efficient binary patching.";
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 static PyObject *mpatch_Error;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
struct frag {
int start, end, len;
char *data;
};
struct flist {
struct frag *base, *head, *tail;
};
static struct flist *lalloc(int size)
{
mpm@selenic.com
Add safety checking to mpatch
r128 struct flist *a = NULL;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
TK Soh
do proper typecasting on malloc() and calloc() calls...
r1978 a = (struct flist *)malloc(sizeof(struct flist));
mpm@selenic.com
Add safety checking to mpatch
r128 if (a) {
TK Soh
do proper typecasting on malloc() and calloc() calls...
r1978 a->base = (struct frag *)malloc(sizeof(struct frag) * size);
Thomas Arendsen Hein
Set correct exception for another possible malloc error in mpatch.c
r2048 if (a->base) {
mpm@selenic.com
Add safety checking to mpatch
r128 a->head = a->tail = a->base;
Thomas Arendsen Hein
Set correct exception for another possible malloc error in mpatch.c
r2048 return a;
}
free(a);
a = NULL;
mpm@selenic.com
Add safety checking to mpatch
r128 }
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (!PyErr_Occurred())
PyErr_NoMemory();
return NULL;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
static void lfree(struct flist *a)
{
mpm@selenic.com
Add safety checking to mpatch
r128 if (a) {
free(a->base);
free(a);
}
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
static int lsize(struct flist *a)
{
return a->tail - a->head;
}
/* move hunks in source that are less cut to dest, compensating
for changes in offset. the last hunk may be split if necessary.
*/
static int gather(struct flist *dest, struct flist *src, int cut, int offset)
{
struct frag *d = dest->tail, *s = src->head;
int postend, c, l;
while (s != src->tail) {
if (s->start + offset >= cut)
mpm@selenic.com
Gotos are embarrassing.
r82 break; /* we've gone far enough */
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
postend = offset + s->start + s->len;
if (postend <= cut) {
/* save this hunk */
offset += s->start + s->len - s->end;
*d++ = *s++;
}
else {
/* break up this hunk */
c = cut - offset;
if (s->end < c)
c = s->end;
l = cut - offset - s->start;
if (s->len < l)
l = s->len;
offset += s->start + l - c;
d->start = s->start;
d->end = c;
d->len = l;
d->data = s->data;
d++;
s->start = c;
s->len = s->len - l;
s->data = s->data + l;
mpm@selenic.com
Gotos are embarrassing.
r82 break;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
}
dest->tail = d;
src->head = s;
return offset;
}
/* like gather, but with no output list */
static int discard(struct flist *src, int cut, int offset)
{
struct frag *s = src->head;
int postend, c, l;
while (s != src->tail) {
if (s->start + offset >= cut)
mpm@selenic.com
Gotos are embarrassing.
r82 break;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
postend = offset + s->start + s->len;
if (postend <= cut) {
offset += s->start + s->len - s->end;
s++;
}
else {
c = cut - offset;
if (s->end < c)
c = s->end;
l = cut - offset - s->start;
if (s->len < l)
l = s->len;
offset += s->start + l - c;
s->start = c;
s->len = s->len - l;
s->data = s->data + l;
mpm@selenic.com
Gotos are embarrassing.
r82 break;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
}
src->head = s;
return offset;
}
/* combine hunk lists a and b, while adjusting b for offset changes in a/
this deletes a and b and returns the resultant list. */
static struct flist *combine(struct flist *a, struct flist *b)
{
mpm@selenic.com
Add safety checking to mpatch
r128 struct flist *c = NULL;
struct frag *bh, *ct;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 int offset = 0, post;
mpm@selenic.com
Add safety checking to mpatch
r128 if (a && b)
c = lalloc((lsize(a) + lsize(b)) * 2);
if (c) {
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
mpm@selenic.com
Add safety checking to mpatch
r128 for (bh = b->head; bh != b->tail; bh++) {
/* save old hunks */
offset = gather(c, a, bh->start, offset);
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
mpm@selenic.com
Add safety checking to mpatch
r128 /* discard replaced hunks */
post = discard(a, bh->end, offset);
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
mpm@selenic.com
Add safety checking to mpatch
r128 /* insert new hunk */
ct = c->tail;
ct->start = bh->start - offset;
ct->end = bh->end - post;
ct->len = bh->len;
ct->data = bh->data;
c->tail++;
offset = post;
}
/* hold on to tail from a */
memcpy(c->tail, a->head, sizeof(struct frag) * lsize(a));
c->tail += lsize(a);
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
lfree(a);
lfree(b);
return c;
}
/* decode a binary patch into a hunk list */
static struct flist *decode(char *bin, int len)
{
struct flist *l;
struct frag *lt;
char *end = bin + len;
mpm@selenic.com
mpatch: attempt to handle unpack alignment issues on Solaris...
r384 char decode[12]; /* for dealing with alignment issues */
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
/* assume worst case size, we won't have many of these lists */
l = lalloc(len / 12);
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (!l)
return NULL;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 lt = l->tail;
while (bin < end) {
mpm@selenic.com
mpatch: attempt to handle unpack alignment issues on Solaris...
r384 memcpy(decode, bin, 12);
lt->start = ntohl(*(uint32_t *)decode);
lt->end = ntohl(*(uint32_t *)(decode + 4));
lt->len = ntohl(*(uint32_t *)(decode + 8));
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 lt->data = bin + 12;
bin += 12 + lt->len;
lt++;
}
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (bin != end) {
if (!PyErr_Occurred())
PyErr_SetString(mpatch_Error, "patch cannot be decoded");
lfree(l);
return NULL;
}
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 l->tail = lt;
return l;
}
/* calculate the size of resultant text */
static int calcsize(int len, struct flist *l)
{
int outlen = 0, last = 0;
struct frag *f = l->head;
while (f != l->tail) {
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (f->start < last || f->end > len) {
if (!PyErr_Occurred())
PyErr_SetString(mpatch_Error,
"invalid patch");
return -1;
}
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 outlen += f->start - last;
last = f->end;
outlen += f->len;
f++;
}
outlen += len - last;
return outlen;
}
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 static int apply(char *buf, char *orig, int len, struct flist *l)
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 {
struct frag *f = l->head;
int last = 0;
char *p = buf;
while (f != l->tail) {
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (f->start < last || f->end > len) {
if (!PyErr_Occurred())
PyErr_SetString(mpatch_Error,
"invalid patch");
return 0;
}
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 memcpy(p, orig + last, f->start - last);
p += f->start - last;
memcpy(p, f->data, f->len);
last = f->end;
p += f->len;
f++;
}
memcpy(p, orig + last, len - last);
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 return 1;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
/* recursively generate a patch of all bins between start and end */
static struct flist *fold(PyObject *bins, int start, int end)
{
int len;
if (start + 1 == end) {
/* trivial case, output a decoded list */
PyObject *tmp = PyList_GetItem(bins, start);
mpm@selenic.com
Add safety checking to mpatch
r128 if (!tmp)
return NULL;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 return decode(PyString_AsString(tmp), PyString_Size(tmp));
}
/* divide and conquer, memory management is elsewhere */
len = (end - start) / 2;
return combine(fold(bins, start, start + len),
fold(bins, start + len, end));
}
static PyObject *
patches(PyObject *self, PyObject *args)
{
PyObject *text, *bins, *result;
struct flist *patch;
char *in, *out;
int len, outlen;
mpm@selenic.com
Add safety checking to mpatch
r128 if (!PyArg_ParseTuple(args, "SO:mpatch", &text, &bins))
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 return NULL;
len = PyList_Size(bins);
if (!len) {
/* nothing to do */
Py_INCREF(text);
return text;
}
patch = fold(bins, 0, len);
mpm@selenic.com
Add safety checking to mpatch
r128 if (!patch)
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 return NULL;
mpm@selenic.com
Add safety checking to mpatch
r128
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 outlen = calcsize(PyString_Size(text), patch);
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (outlen < 0) {
result = NULL;
goto cleanup;
}
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 result = PyString_FromStringAndSize(NULL, outlen);
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (!result) {
result = NULL;
goto cleanup;
mpm@selenic.com
Add safety checking to mpatch
r128 }
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 in = PyString_AsString(text);
out = PyString_AsString(result);
if (!apply(out, in, PyString_Size(text), patch)) {
Py_DECREF(result);
result = NULL;
}
cleanup:
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 lfree(patch);
return result;
}
mason@suse.com
Fill in the uncompressed size during revlog.addgroup...
r2078 /* calculate size of a patched file directly */
static PyObject *
patchedsize(PyObject *self, PyObject *args)
{
long orig, start, end, len, outlen = 0, last = 0;
int patchlen;
char *bin, *binend;
char decode[12]; /* for dealing with alignment issues */
if (!PyArg_ParseTuple(args, "ls#", &orig, &bin, &patchlen))
return NULL;
binend = bin + patchlen;
while (bin < binend) {
memcpy(decode, bin, 12);
start = ntohl(*(uint32_t *)decode);
end = ntohl(*(uint32_t *)(decode + 4));
len = ntohl(*(uint32_t *)(decode + 8));
bin += 12 + len;
outlen += start - last;
last = end;
outlen += len;
}
if (bin != binend) {
if (!PyErr_Occurred())
PyErr_SetString(mpatch_Error, "patch cannot be decoded");
return NULL;
}
outlen += orig - last;
return Py_BuildValue("l", outlen);
}
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 static PyMethodDef methods[] = {
{"patches", patches, METH_VARARGS, "apply a series of patches\n"},
mason@suse.com
Fill in the uncompressed size during revlog.addgroup...
r2078 {"patchedsize", patchedsize, METH_VARARGS, "calculed patched size\n"},
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 {NULL, NULL}
};
PyMODINIT_FUNC
initmpatch(void)
{
Py_InitModule3("mpatch", methods, mpatch_doc);
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 mpatch_Error = PyErr_NewException("mpatch.mpatchError", NULL, NULL);
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }