rebase: use cmdutil.check_at_most_one_arg() for -b/-s/-r

Differential Revision: https://phab.mercurial-scm.org/D7643

hgext/rebase.py

@@ -1025,6 +1025,7 b' def rebase(ui, repo, **opts):'
             opts, action, b'confirm', b'dry_run'
         )
     cmdutil.check_at_most_one_arg(opts, b'confirm', b'dry_run')
+    cmdutil.check_at_most_one_arg(opts, b'rev', b'source', b'base')
 
     if action or repo.currenttransaction() is not None:
         # in-memory rebase is not compatible with resuming rebases.
@@ -1259,12 +1260,6 b' def _definedestmap('
 
     # destspace is here to work around issues with `hg pull --rebase` see
     # issue5214 for details
-    if srcf and basef:
-        raise error.Abort(_(b'cannot specify both a source and a base'))
-    if revf and basef:
-        raise error.Abort(_(b'cannot specify both a revision and a base'))
-    if revf and srcf:
-        raise error.Abort(_(b'cannot specify both a revision and a source'))
 
     cmdutil.checkunfinished(repo)
     if not inmemory:

tests/test-rebase-parameters.t

@@ -73,14 +73,14 b' These fail:'
   [255]
 
   $ hg rebase --base 5 --source 4
-  abort: cannot specify both a source and a base
+  abort: cannot specify both --source and --base
   [255]
 
   $ hg rebase --rev 5 --source 4
-  abort: cannot specify both a revision and a source
+  abort: cannot specify both --rev and --source
   [255]
   $ hg rebase --base 5 --rev 4
-  abort: cannot specify both a revision and a base
+  abort: cannot specify both --rev and --base
   [255]
 
   $ hg rebase --base 6