Show More
@@ -1,54 +1,55 b'' | |||||
1 | #!/usr/bin/env python |
|
1 | #!/usr/bin/env python | |
2 | # |
|
2 | # | |
3 | # Copyright 2014 Matt Mackall <mpm@selenic.com> |
|
3 | # Copyright 2014 Matt Mackall <mpm@selenic.com> | |
4 | # |
|
4 | # | |
5 | # A tool/hook to run basic sanity checks on commits/patches for |
|
5 | # A tool/hook to run basic sanity checks on commits/patches for | |
6 | # submission to Mercurial. Install by adding the following to your |
|
6 | # submission to Mercurial. Install by adding the following to your | |
7 | # .hg/hgrc: |
|
7 | # .hg/hgrc: | |
8 | # |
|
8 | # | |
9 | # [hooks] |
|
9 | # [hooks] | |
10 | # pretxncommit = contrib/check-commit |
|
10 | # pretxncommit = contrib/check-commit | |
11 | # |
|
11 | # | |
12 | # The hook can be temporarily bypassed with: |
|
12 | # The hook can be temporarily bypassed with: | |
13 | # |
|
13 | # | |
14 | # $ BYPASS= hg commit |
|
14 | # $ BYPASS= hg commit | |
15 | # |
|
15 | # | |
16 | # See also: http://mercurial.selenic.com/wiki/ContributingChanges |
|
16 | # See also: http://mercurial.selenic.com/wiki/ContributingChanges | |
17 |
|
17 | |||
18 | import re, sys, os |
|
18 | import re, sys, os | |
19 |
|
19 | |||
20 | errors = [ |
|
20 | errors = [ | |
21 | (r"[(]bc[)]", "(BC) needs to be uppercase"), |
|
21 | (r"[(]bc[)]", "(BC) needs to be uppercase"), | |
22 | (r"[(]issue \d\d\d", "no space allowed between issue and number"), |
|
22 | (r"[(]issue \d\d\d", "no space allowed between issue and number"), | |
23 | (r"[(]bug", "use (issueDDDD) instead of bug"), |
|
23 | (r"[(]bug", "use (issueDDDD) instead of bug"), | |
24 | (r"^# User [^@\n]+$", "username is not an email address"), |
|
24 | (r"^# User [^@\n]+$", "username is not an email address"), | |
25 | (r"^# .*\n(?!merge with )[^#]\S+[^:] ", |
|
25 | (r"^# .*\n(?!merge with )[^#]\S+[^:] ", | |
26 | "summary line doesn't start with 'topic: '"), |
|
26 | "summary line doesn't start with 'topic: '"), | |
27 | (r"^# .*\n[A-Z][a-z]\S+", "don't capitalize summary lines"), |
|
27 | (r"^# .*\n[A-Z][a-z]\S+", "don't capitalize summary lines"), | |
28 | (r"^# .*\n.*\.\s+$", "don't add trailing period on summary line"), |
|
28 | (r"^# .*\n.*\.\s+$", "don't add trailing period on summary line"), | |
29 | (r"^# .*\n.{78,}", "summary line too long"), |
|
29 | (r"^# .*\n.{78,}", "summary line too long"), | |
|
30 | (r"^\+\n \n", "adds double empty line"), | |||
30 | (r"\+\s+def [a-z]+_[a-z]", "adds a function with foo_bar naming"), |
|
31 | (r"\+\s+def [a-z]+_[a-z]", "adds a function with foo_bar naming"), | |
31 | ] |
|
32 | ] | |
32 |
|
33 | |||
33 | node = os.environ.get("HG_NODE") |
|
34 | node = os.environ.get("HG_NODE") | |
34 |
|
35 | |||
35 | if node: |
|
36 | if node: | |
36 | commit = os.popen("hg export %s" % node).read() |
|
37 | commit = os.popen("hg export %s" % node).read() | |
37 | else: |
|
38 | else: | |
38 | commit = sys.stdin.read() |
|
39 | commit = sys.stdin.read() | |
39 |
|
40 | |||
40 | exitcode = 0 |
|
41 | exitcode = 0 | |
41 | for exp, msg in errors: |
|
42 | for exp, msg in errors: | |
42 | m = re.search(exp, commit, re.MULTILINE) |
|
43 | m = re.search(exp, commit, re.MULTILINE) | |
43 | if m: |
|
44 | if m: | |
44 | pos = 0 |
|
45 | pos = 0 | |
45 | for n, l in enumerate(commit.splitlines(True)): |
|
46 | for n, l in enumerate(commit.splitlines(True)): | |
46 | pos += len(l) |
|
47 | pos += len(l) | |
47 | if pos >= m.end(): |
|
48 | if pos >= m.end(): | |
48 | print "%d: %s" % (n, msg) |
|
49 | print "%d: %s" % (n, msg) | |
49 | print " %s" % l[:-1] |
|
50 | print " %s" % l[:-1] | |
50 | if "BYPASS" not in os.environ: |
|
51 | if "BYPASS" not in os.environ: | |
51 | exitcode = 1 |
|
52 | exitcode = 1 | |
52 | break |
|
53 | break | |
53 |
|
54 | |||
54 | sys.exit(exitcode) |
|
55 | sys.exit(exitcode) |
General Comments 0
You need to be logged in to leave comments.
Login now