qnew: give better feedback when doing 'hg qnew foo/' (issue2464)

hgext/mq.py

@@ -839,8 +839,12 b' class queue(object):'
         insert = self.full_series_end()
         wlock = repo.wlock()
         try:
-            # if patch file write fails, abort early
-            p = self.opener(patchfn, "w")
+            try:
+                # if patch file write fails, abort early
+                p = self.opener(patchfn, "w")
+            except IOError, e:
+                raise util.Abort(_('cannot write patch "%s": %s')
+                                 % (patchfn, e.strerror))
             try:
                 if self.plainmode:
                     if user:

tests/test-mq-qnew.t

@@ -23,6 +23,7 b''
   >     hg qinit -c
   > 
   >     echo '% qnew with name containing slash'
+  >     hg qnew foo/
   >     hg qnew foo/bar.patch
   >     hg qseries
   >     hg qpop
@@ -105,6 +106,7 b' plain headers'
   abort: "foo#bar" cannot be used as the name of a patch
   abort: "foo:bar" cannot be used as the name of a patch
   % qnew with name containing slash
+  abort: cannot write patch "foo/": Is a directory
   foo/bar.patch
   popping foo/bar.patch
   patch queue now empty
@@ -168,6 +170,7 b' hg headers'
   abort: "foo#bar" cannot be used as the name of a patch
   abort: "foo:bar" cannot be used as the name of a patch
   % qnew with name containing slash
+  abort: cannot write patch "foo/": Is a directory
   foo/bar.patch
   popping foo/bar.patch
   patch queue now empty