setdiscovery: return anyincoming=False when remote's only head is nullid

This fixes (issue2907) a crash when using 'hg incoming --bundle' with an empty
remote repo and a non-empty local repo.

This also fixes an unreported bug that 'hg summary --remote' erroneously
reports incoming changes when the remote repo is empty and the local is not.

Also, add a test to make sure issue2907 stays fixed

mercurial/setdiscovery.py

@@ -1,193 +1,194 b''
 # setdiscovery.py - improved discovery of common nodeset for mercurial
 #
 # Copyright 2010 Benoit Boissinot <[e-mail]>
 # and Peter Arrenbrecht <[e-mail]>
 #
 # This software may be used and distributed according to the terms of the
 # GNU General Public License version 2 or any later version.
 
 from node import nullid
 from i18n import _
 import random, collections, util, dagutil
 
 def _updatesample(dag, nodes, sample, always, quicksamplesize=0):
     # if nodes is empty we scan the entire graph
     if nodes:
         heads = dag.headsetofconnecteds(nodes)
     else:
         heads = dag.heads()
     dist = {}
     visit = collections.deque(heads)
     seen = set()
     factor = 1
     while visit:
         curr = visit.popleft()
         if curr in seen:
             continue
         d = dist.setdefault(curr, 1)
         if d > factor:
             factor *= 2
         if d == factor:
             if curr not in always: # need this check for the early exit below
                 sample.add(curr)
                 if quicksamplesize and (len(sample) >= quicksamplesize):
                     return
         seen.add(curr)
         for p in dag.parents(curr):
             if not nodes or p in nodes:
                 dist.setdefault(p, d + 1)
                 visit.append(p)
 
 def _setupsample(dag, nodes, size):
     if len(nodes) <= size:
         return set(nodes), None, 0
     always = set(dag.heads())
     desiredlen = size - len(always)
     if desiredlen <= 0:
         # This could be bad if there are very many heads, all unknown to the
         # server. We're counting on long request support here.
         return always, None, desiredlen
     return always, set(), desiredlen
 
 def _takequicksample(dag, nodes, size, initial):
     always, sample, desiredlen = _setupsample(dag, nodes, size)
     if sample is None:
         return always
     if initial:
         fromset = None
     else:
         fromset = nodes
     _updatesample(dag, fromset, sample, always, quicksamplesize=desiredlen)
     sample.update(always)
     return sample
 
 def _takefullsample(dag, nodes, size):
     always, sample, desiredlen = _setupsample(dag, nodes, size)
     if sample is None:
         return always
     # update from heads
     _updatesample(dag, nodes, sample, always)
     # update from roots
     _updatesample(dag.inverse(), nodes, sample, always)
     assert sample
     if len(sample) > desiredlen:
         sample = set(random.sample(sample, desiredlen))
     elif len(sample) < desiredlen:
         more = desiredlen - len(sample)
         sample.update(random.sample(list(nodes - sample - always), more))
     sample.update(always)
     return sample
 
 def findcommonheads(ui, local, remote,
                     initialsamplesize=100,
                     fullsamplesize=200,
                     abortwhenunrelated=True):
     '''Return a tuple (common, anyincoming, remoteheads) used to identify
     missing nodes from or in remote.
 
     shortcutlocal determines whether we try use direct access to localrepo if
     remote is actually local.
     '''
     roundtrips = 0
     cl = local.changelog
     dag = dagutil.revlogdag(cl)
 
     # early exit if we know all the specified remote heads already
     ui.debug("query 1; heads\n")
     roundtrips += 1
     ownheads = dag.heads()
     sample = ownheads
     if remote.local():
         # stopgap until we have a proper localpeer that supports batch()
         srvheadhashes = remote.heads()
         yesno = remote.known(dag.externalizeall(sample))
     elif remote.capable('batch'):
         batch = remote.batch()
         srvheadhashesref = batch.heads()
         yesnoref = batch.known(dag.externalizeall(sample))
         batch.submit()
         srvheadhashes = srvheadhashesref.value
         yesno = yesnoref.value
     else:
         # compatibitity with pre-batch, but post-known remotes during 1.9 devel
         srvheadhashes = remote.heads()
         sample = []
 
     if cl.tip() == nullid:
         if srvheadhashes != [nullid]:
             return [nullid], True, srvheadhashes
         return [nullid], False, []
 
     # start actual discovery (we note this before the next "if" for
     # compatibility reasons)
     ui.status(_("searching for changes\n"))
 
     srvheads = dag.internalizeall(srvheadhashes, filterunknown=True)
     if len(srvheads) == len(srvheadhashes):
         ui.debug("all remote heads known locally\n")
         return (srvheadhashes, False, srvheadhashes,)
 
     if sample and util.all(yesno):
         ui.note("all local heads known remotely\n")
         ownheadhashes = dag.externalizeall(ownheads)
         return (ownheadhashes, True, srvheadhashes,)
 
     # full blown discovery
     undecided = dag.nodeset() # own nodes where I don't know if remote knows them
     common = set() # own nodes I know we both know
     missing = set() # own nodes I know remote lacks
 
     # treat remote heads (and maybe own heads) as a first implicit sample response
     common.update(dag.ancestorset(srvheads))
     undecided.difference_update(common)
 
     full = False
     while undecided:
 
         if sample:
             commoninsample = set(n for i, n in enumerate(sample) if yesno[i])
             common.update(dag.ancestorset(commoninsample, common))
 
             missinginsample = [n for i, n in enumerate(sample) if not yesno[i]]
             missing.update(dag.descendantset(missinginsample, missing))
 
             undecided.difference_update(missing)
             undecided.difference_update(common)
 
         if not undecided:
             break
 
         if full:
             ui.note("sampling from both directions\n")
             sample = _takefullsample(dag, undecided, size=fullsamplesize)
         elif common:
             # use cheapish initial sample
             ui.debug("taking initial sample\n")
             sample = _takefullsample(dag, undecided, size=fullsamplesize)
         else:
             # use even cheaper initial sample
             ui.debug("taking quick initial sample\n")
             sample = _takequicksample(dag, undecided, size=initialsamplesize,
                                       initial=True)
 
         roundtrips += 1
         ui.progress(_('searching'), roundtrips, unit=_('queries'))
         ui.debug("query %i; still undecided: %i, sample size is: %i\n"
                  % (roundtrips, len(undecided), len(sample)))
         # indices between sample and externalized version must match
         sample = list(sample)
         yesno = remote.known(dag.externalizeall(sample))
         full = True
 
     result = dag.headsetofconnecteds(common)
     ui.progress(_('searching'), None)
     ui.debug("%d total queries\n" % roundtrips)
 
     if not result and srvheadhashes != [nullid]:
         if abortwhenunrelated:
             raise util.Abort(_("repository is unrelated"))
         else:
             ui.warn(_("warning: repository is unrelated\n"))
         return (set([nullid]), True, srvheadhashes,)
 
-    return (dag.externalizeall(result), True, srvheadhashes,)
+    anyincoming = (srvheadhashes != [nullid])
+    return dag.externalizeall(result), anyincoming, srvheadhashes

tests/test-incoming-outgoing.t

@@ -1,467 +1,480 b''
   $ hg init test
   $ cd test
   $ for i in 0 1 2 3 4 5 6 7 8; do
   >     echo $i >> foo
   >     hg commit -A -m $i
   > done
   adding foo
   $ hg verify
   checking changesets
   checking manifests
   crosschecking files in changesets and manifests
   checking files
   1 files, 9 changesets, 9 total revisions
   $ hg serve -p $HGPORT -d --pid-file=hg.pid
   $ cat hg.pid >> $DAEMON_PIDS
   $ cd ..
 
   $ hg init new
 
 http incoming
 
   $ hg -R new incoming http://localhost:$HGPORT/
   comparing with http://localhost:$HGPORT/
   changeset:   0:00a43fa82f62
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     0
   
   changeset:   1:5460a410df01
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     1
   
   changeset:   2:d9f42cd1a1ec
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     2
   
   changeset:   3:376476025137
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     3
   
   changeset:   4:70d7eb252d49
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     4
   
   changeset:   5:ad284ee3b5ee
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     5
   
   changeset:   6:e9229f2de384
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     6
   
   changeset:   7:d152815bb8db
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     7
   
   changeset:   8:e4feb4ac9035
   tag:         tip
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     8
   
   $ hg -R new incoming -r 4 http://localhost:$HGPORT/
   comparing with http://localhost:$HGPORT/
   changeset:   0:00a43fa82f62
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     0
   
   changeset:   1:5460a410df01
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     1
   
   changeset:   2:d9f42cd1a1ec
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     2
   
   changeset:   3:376476025137
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     3
   
   changeset:   4:70d7eb252d49
   tag:         tip
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     4
   
 
 local incoming
 
   $ hg -R new incoming test
   comparing with test
   changeset:   0:00a43fa82f62
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     0
   
   changeset:   1:5460a410df01
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     1
   
   changeset:   2:d9f42cd1a1ec
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     2
   
   changeset:   3:376476025137
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     3
   
   changeset:   4:70d7eb252d49
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     4
   
   changeset:   5:ad284ee3b5ee
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     5
   
   changeset:   6:e9229f2de384
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     6
   
   changeset:   7:d152815bb8db
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     7
   
   changeset:   8:e4feb4ac9035
   tag:         tip
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     8
   
   $ hg -R new incoming -r 4 test
   comparing with test
   changeset:   0:00a43fa82f62
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     0
   
   changeset:   1:5460a410df01
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     1
   
   changeset:   2:d9f42cd1a1ec
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     2
   
   changeset:   3:376476025137
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     3
   
   changeset:   4:70d7eb252d49
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     4
   
 
 limit to 2 changesets
 
   $ hg -R new incoming -l 2 test
   comparing with test
   changeset:   0:00a43fa82f62
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     0
   
   changeset:   1:5460a410df01
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     1
   
 
 limit to 2 changesets, test with -p --git
 
   $ hg -R new incoming -l 2 -p --git test
   comparing with test
   changeset:   0:00a43fa82f62
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     0
   
   diff --git a/foo b/foo
   new file mode 100644
   --- /dev/null
   +++ b/foo
   @@ -0,0 +1,1 @@
   +0
   
   changeset:   1:5460a410df01
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     1
   
   diff --git a/foo b/foo
   --- a/foo
   +++ b/foo
   @@ -1,1 +1,2 @@
    0
   +1
   
 
 test with --bundle
 
   $ hg -R new incoming --bundle test.hg http://localhost:$HGPORT/
   comparing with http://localhost:$HGPORT/
   changeset:   0:00a43fa82f62
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     0
   
   changeset:   1:5460a410df01
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     1
   
   changeset:   2:d9f42cd1a1ec
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     2
   
   changeset:   3:376476025137
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     3
   
   changeset:   4:70d7eb252d49
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     4
   
   changeset:   5:ad284ee3b5ee
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     5
   
   changeset:   6:e9229f2de384
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     6
   
   changeset:   7:d152815bb8db
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     7
   
   changeset:   8:e4feb4ac9035
   tag:         tip
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     8
   
   $ hg -R new incoming --bundle test2.hg test
   comparing with test
   changeset:   0:00a43fa82f62
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     0
   
   changeset:   1:5460a410df01
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     1
   
   changeset:   2:d9f42cd1a1ec
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     2
   
   changeset:   3:376476025137
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     3
   
   changeset:   4:70d7eb252d49
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     4
   
   changeset:   5:ad284ee3b5ee
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     5
   
   changeset:   6:e9229f2de384
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     6
   
   changeset:   7:d152815bb8db
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     7
   
   changeset:   8:e4feb4ac9035
   tag:         tip
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     8
   
 
 
 test the resulting bundles
 
   $ hg init temp
   $ hg init temp2
   $ hg -R temp unbundle test.hg
   adding changesets
   adding manifests
   adding file changes
   added 9 changesets with 9 changes to 1 files
   (run 'hg update' to get a working copy)
   $ hg -R temp2 unbundle test2.hg
   adding changesets
   adding manifests
   adding file changes
   added 9 changesets with 9 changes to 1 files
   (run 'hg update' to get a working copy)
   $ hg -R temp tip
   changeset:   8:e4feb4ac9035
   tag:         tip
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     8
   
   $ hg -R temp2 tip
   changeset:   8:e4feb4ac9035
   tag:         tip
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     8
   
 
   $ rm -r temp temp2 new
 
 test outgoing
 
   $ hg clone test test-dev
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cd test-dev
   $ for i in 9 10 11 12 13; do
   >     echo $i >> foo
   >     hg commit -A -m $i
   > done
   $ hg verify
   checking changesets
   checking manifests
   crosschecking files in changesets and manifests
   checking files
   1 files, 14 changesets, 14 total revisions
   $ cd ..
   $ hg -R test-dev outgoing test
   comparing with test
   searching for changes
   changeset:   9:d89d4abea5bc
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     9
   
   changeset:   10:820095aa7158
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     10
   
   changeset:   11:09ede2f3a638
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     11
   
   changeset:   12:e576b1bed305
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     12
   
   changeset:   13:96bbff09a7cc
   tag:         tip
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     13
   
 
 limit to 3 changesets
 
   $ hg -R test-dev outgoing -l 3 test
   comparing with test
   searching for changes
   changeset:   9:d89d4abea5bc
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     9
   
   changeset:   10:820095aa7158
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     10
   
   changeset:   11:09ede2f3a638
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     11
   
   $ hg -R test-dev outgoing http://localhost:$HGPORT/
   comparing with http://localhost:$HGPORT/
   searching for changes
   changeset:   9:d89d4abea5bc
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     9
   
   changeset:   10:820095aa7158
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     10
   
   changeset:   11:09ede2f3a638
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     11
   
   changeset:   12:e576b1bed305
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     12
   
   changeset:   13:96bbff09a7cc
   tag:         tip
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     13
   
   $ hg -R test-dev outgoing -r 11 http://localhost:$HGPORT/
   comparing with http://localhost:$HGPORT/
   searching for changes
   changeset:   9:d89d4abea5bc
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     9
   
   changeset:   10:820095aa7158
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     10
   
   changeset:   11:09ede2f3a638
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     11
   
+
+incoming from empty remote repository
+
+  $ hg init r1
+  $ hg init r2
+  $ echo a > r1/foo
+  $ hg -R r1 ci -Ama
+  adding foo
+  $ hg -R r1 incoming r2 --bundle x.hg
+  comparing with r2
+  searching for changes
+  no changes found
+  [1]