py3: make sure we open files in bytes mode

we internally deal with bytes and should read files in bytes mode.

Differential Revision: https://phab.mercurial-scm.org/D3606

hgext/churn.py

@@ -161,7 +161,7 b' def churn(ui, repo, *pats, **opts):'
     if not aliases and os.path.exists(repo.wjoin('.hgchurn')):
         aliases = repo.wjoin('.hgchurn')
     if aliases:
-        for l in open(aliases, "r"):
+        for l in open(aliases, "rb"):
             try:
                 alias, actual = l.rsplit('=' in l and '=' or None, 1)
                 amap[alias.strip()] = actual.strip()

mercurial/crecord.py

@@ -554,7 +554,7 b' def testchunkselector(testfn, ui, header'
     """
     chunkselector = curseschunkselector(headerlist, ui, operation)
     if testfn and os.path.exists(testfn):
-        testf = open(testfn)
+        testf = open(testfn, 'rb')
         testcommands = [x.rstrip('\n') for x in testf.readlines()]
         testf.close()
         while True: