push: move obsolescence marker exchange in the exchange module

The obsolescence marker exchange code was already extracted during a previous
cycle. We are moving the extracted functio in this module. This function will
read and write data in the `pushoperation` object and I prefer to have all core
function collaborating through this object in the same place.

This changeset is pure code movement only. Code change for direct consumption of
the `pushoperation` object will come later.

mercurial/exchange.py

@@ -247,7 +247,7 def push(repo, remote, force=False, revs
                         pushop.ui.warn(_('updating %s to public failed!\n')
                                        % newremotehead)
             pushop.ui.debug('try to push obsolete markers to remote\n')
-            obsolete.syncpush(pushop.repo, pushop.remote)
+            _pushobsolete(pushop.repo, pushop.remote)
         finally:
             if lock is not None:
                 lock.release()
@@ -258,6 +258,22 def push(repo, remote, force=False, revs
     _pushbookmark(pushop)
     return ret
 
+def _pushobsolete(repo, remote):
+    """utility function to push obsolete markers to a remote
+
+    Exist mostly to allow overriding for experimentation purpose"""
+    if (obsolete._enabled and repo.obsstore and
+        'obsolete' in remote.listkeys('namespaces')):
+        rslts = []
+        remotedata = repo.listkeys('obsolete')
+        for key in sorted(remotedata, reverse=True):
+            # reverse sort to ensure we end with dump0
+            data = remotedata[key]
+            rslts.append(remote.pushkey('obsolete', key, '', data))
+        if [r for r in rslts if not r]:
+            msg = _('failed to push some obsolete markers!\n')
+            repo.ui.warn(msg)
+
 def _pushbookmark(pushop):
     """Update bookmark position on remote"""
     ui = pushop.ui

mercurial/obsolete.py

@@ -384,22 +384,6 def pushmarker(repo, key, old, new):
     finally:
         lock.release()
 
-def syncpush(repo, remote):
-    """utility function to push obsolete markers to a remote
-
-    Exist mostly to allow overriding for experimentation purpose"""
-    if (_enabled and repo.obsstore and
-        'obsolete' in remote.listkeys('namespaces')):
-        rslts = []
-        remotedata = repo.listkeys('obsolete')
-        for key in sorted(remotedata, reverse=True):
-            # reverse sort to ensure we end with dump0
-            data = remotedata[key]
-            rslts.append(remote.pushkey('obsolete', key, '', data))
-        if [r for r in rslts if not r]:
-            msg = _('failed to push some obsolete markers!\n')
-            repo.ui.warn(msg)
-
 def syncpull(repo, remote, gettransaction):
     """utility function to pull obsolete markers from a remote