##// END OF EJS Templates
revlog: avoid shadowing several variables using list comprehensions
Augie Fackler -
r30391:2ded17b6 default
parent child Browse files
Show More
@@ -597,7 +597,7 b' class revlog(object):'
597 visit.append(p)
597 visit.append(p)
598 missing = list(missing)
598 missing = list(missing)
599 missing.sort()
599 missing.sort()
600 return has, [self.node(r) for r in missing]
600 return has, [self.node(miss) for miss in missing]
601
601
602 def incrementalmissingrevs(self, common=None):
602 def incrementalmissingrevs(self, common=None):
603 """Return an object that can be used to incrementally compute the
603 """Return an object that can be used to incrementally compute the
@@ -749,10 +749,10 b' class revlog(object):'
749 # include roots that aren't ancestors.
749 # include roots that aren't ancestors.
750
750
751 # Filter out roots that aren't ancestors of heads
751 # Filter out roots that aren't ancestors of heads
752 roots = [n for n in roots if n in ancestors]
752 roots = [root for root in roots if root in ancestors]
753 # Recompute the lowest revision
753 # Recompute the lowest revision
754 if roots:
754 if roots:
755 lowestrev = min([self.rev(n) for n in roots])
755 lowestrev = min([self.rev(root) for root in roots])
756 else:
756 else:
757 # No more roots? Return empty list
757 # No more roots? Return empty list
758 return nonodes
758 return nonodes
@@ -811,7 +811,7 b' class revlog(object):'
811 # But, obviously its parents aren't.
811 # But, obviously its parents aren't.
812 for p in self.parents(n):
812 for p in self.parents(n):
813 heads.pop(p, None)
813 heads.pop(p, None)
814 heads = [n for n, flag in heads.iteritems() if flag]
814 heads = [head for head, flag in heads.iteritems() if flag]
815 roots = list(roots)
815 roots = list(roots)
816 assert orderedout
816 assert orderedout
817 assert roots
817 assert roots
@@ -963,9 +963,9 b' class revlog(object):'
963
963
964 def _partialmatch(self, id):
964 def _partialmatch(self, id):
965 try:
965 try:
966 n = self.index.partialmatch(id)
966 partial = self.index.partialmatch(id)
967 if n and self.hasnode(n):
967 if partial and self.hasnode(partial):
968 return n
968 return partial
969 return None
969 return None
970 except RevlogError:
970 except RevlogError:
971 # parsers.c radix tree lookup gave multiple matches
971 # parsers.c radix tree lookup gave multiple matches
General Comments 0
You need to be logged in to leave comments. Login now