tests: remove last two check-code warnings about killdaemons

Removes the last of the warnings in test-check-code-hg.t introduced in
667063b22a69.

tests/test-check-code-hg.t

@@ -1,20 +1,13 b''
   $ check_code="$TESTDIR"/../contrib/check-code.py
   $ cd "$TESTDIR"/..
   $ if hg identify -q > /dev/null 2>&1; then :
   > else
   >     echo "skipped: not a Mercurial working dir" >&2
   >     exit 80
   > fi
 
 New errors are not allowed. Warnings are strongly discouraged.
 
   $ hg manifest 2>/dev/null \
   >   | xargs "$check_code" --warnings --nolineno --per-file=0 \
   >   || false
-  tests/test-serve.t:0:
-   >   >        kill `cat hg.pid`
-   don't use kill, use killdaemons.py
-  tests/test-serve.t:0:
-   >   >        kill `cat hg.pid` 2>/dev/null
-   don't use kill, use killdaemons.py
-  [1]

tests/test-serve.t

@@ -1,84 +1,79 b''
   $ "$TESTDIR/hghave" serve || exit 80
 
   $ hgserve()
   > {
   >    hg serve -a localhost -d --pid-file=hg.pid -E errors.log -v $@ \
   >        | sed -e "s/:$HGPORT1\\([^0-9]\\)/:HGPORT1\1/g" \
   >              -e "s/:$HGPORT2\\([^0-9]\\)/:HGPORT2\1/g" \
   >              -e 's/http:\/\/[^/]*\//http:\/\/localhost\//'
   >    cat hg.pid >> "$DAEMON_PIDS"
   >    echo % errors
   >    cat errors.log
-  >    if [ "$KILLQUIETLY" = "Y" ]; then
-  >        kill `cat hg.pid` 2>/dev/null
-  >    else
-  >        kill `cat hg.pid`
-  >    fi
-  >    while kill -0 `cat hg.pid` 2>/dev/null; do sleep 0; done
+  >    "$TESTDIR/killdaemons.py" hg.pid
   > }
 
   $ hg init test
   $ cd test
   $ echo '[web]' > .hg/hgrc
   $ echo 'accesslog = access.log' >> .hg/hgrc
   $ echo "port = $HGPORT1" >> .hg/hgrc
 
 Without -v
 
   $ hg serve -a localhost -p $HGPORT -d --pid-file=hg.pid -E errors.log
   $ cat hg.pid >> "$DAEMON_PIDS"
   $ if [ -f access.log ]; then
   >     echo 'access log created - .hg/hgrc respected'
   > fi
   access log created - .hg/hgrc respected
 
 errors
 
   $ cat errors.log
 
 With -v
 
   $ hgserve
   listening at http://localhost/ (bound to 127.0.0.1:HGPORT1)
   % errors
 
 With -v and -p HGPORT2
 
   $ hgserve -p "$HGPORT2"
   listening at http://localhost/ (bound to 127.0.0.1:HGPORT2)
   % errors
 
 With -v and -p daytime (should fail because low port)
 
   $ KILLQUIETLY=Y
   $ hgserve -p daytime
   abort: cannot start server at 'localhost:13': Permission denied
   abort: child process failed to start
   % errors
   $ KILLQUIETLY=N
 
 With --prefix foo
 
   $ hgserve --prefix foo
   listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1)
   % errors
 
 With --prefix /foo
 
   $ hgserve --prefix /foo
   listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1)
   % errors
 
 With --prefix foo/
 
   $ hgserve --prefix foo/
   listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1)
   % errors
 
 With --prefix /foo/
 
   $ hgserve --prefix /foo/
   listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1)
   % errors
 
   $ cd ..