mq: drop updateheader - inserthgheader and insertplainheader is enough

hgext/mq.py

@@ -303,7 +303,6 class patchheader(object):
                                    for c in self.comments))
 
     def setuser(self, user):
-        if not self.updateheader(['From: ', '# User '], user):
             try:
                 inserthgheader(self.comments, '# User ', user)
             except ValueError:
@@ -315,7 +314,6 class patchheader(object):
         self.user = user
 
     def setdate(self, date):
-        if not self.updateheader(['Date: ', '# Date '], date):
             try:
                 inserthgheader(self.comments, '# Date ', date)
             except ValueError:
@@ -327,8 +325,6 class patchheader(object):
         self.date = date
 
     def setparent(self, parent):
-        if not (self.updateheader(['# Parent  '], parent) or
-                self.updateheader(['# Parent '], parent)):
             try:
                 inserthgheader(self.comments, '# Parent  ', parent)
             except ValueError:
@@ -346,18 +342,6 class patchheader(object):
                 self.comments.append('')
             self.comments.append(message)
 
-    def updateheader(self, prefixes, new):
-        '''Update all references to a field in the patch header.
-        Return whether the field is present.'''
-        res = False
-        for prefix in prefixes:
-            for i in xrange(len(self.comments)):
-                if self.comments[i].startswith(prefix):
-                    self.comments[i] = prefix + new
-                    res = True
-                    break
-        return res
-
     def __str__(self):
         s = '\n'.join(self.comments).rstrip()
         if not s: