children: don't pass filectx to displayer

displayer doesn't want a fctx but a ctx. It failed with -Tdefault template.

    Traceback (most recent call last):
      ...
      File "mercurial/templatekw.py", line 212, in showbookmarks
        bookmarks = args['ctx'].bookmarks()
    AttributeError: 'filectx' object has no attribute 'bookmarks'

hgext/children.py

@@ -1,49 +1,51 b''
 # Mercurial extension to provide the 'hg children' command
 #
 # Copyright 2007 by Intevation GmbH <[e-mail]>
 #
 # Author(s):
 # Thomas Arendsen Hein <[e-mail]>
 #
 # This software may be used and distributed according to the terms of the
 # GNU General Public License version 2 or any later version.
 
 '''command to display child changesets (DEPRECATED)
 
 This extension is deprecated. You should use :hg:`log -r
 "children(REV)"` instead.
 '''
 
 from mercurial import cmdutil
 from mercurial.commands import templateopts
 from mercurial.i18n import _
 
 cmdtable = {}
 command = cmdutil.command(cmdtable)
 testedwith = 'internal'
 
 @command('children',
     [('r', 'rev', '',
      _('show children of the specified revision'), _('REV')),
     ] + templateopts,
     _('hg children [-r REV] [FILE]'),
     inferrepo=True)
 def children(ui, repo, file_=None, **opts):
     """show the children of the given or working directory revision
 
     Print the children of the working directory's revisions. If a
     revision is given via -r/--rev, the children of that revision will
     be printed. If a file argument is given, revision in which the
     file was last changed (after the working directory revision or the
     argument to --rev if given) is printed.
     """
     rev = opts.get('rev')
     if file_:
-        ctx = repo.filectx(file_, changeid=rev)
+        fctx = repo.filectx(file_, changeid=rev)
+        childctxs = [fcctx.changectx() for fcctx in fctx.children()]
     else:
         ctx = repo[rev]
+        childctxs = ctx.children()
 
     displayer = cmdutil.show_changeset(ui, repo, opts)
-    for cctx in ctx.children():
+    for cctx in childctxs:
         displayer.show(cctx)
     displayer.close()

tests/test-children.t

@@ -1,125 +1,133 b''
 test children command
 
   $ cat <<EOF >> $HGRCPATH
   > [extensions]
   > children =
   > EOF
 
 init
   $ hg init t
   $ cd t
 
 no working directory
   $ hg children
 
 setup
   $ echo 0 > file0
   $ hg ci -qAm 0 -d '0 0'
 
   $ echo 1 > file1
   $ hg ci -qAm 1 -d '1 0'
 
   $ echo 2 >> file0
   $ hg ci -qAm 2 -d '2 0'
 
   $ hg co null
   0 files updated, 0 files merged, 2 files removed, 0 files unresolved
   $ echo 3 > file3
   $ hg ci -qAm 3 -d '3 0'
 
 hg children at revision 3 (tip)
   $ hg children
 
   $ hg co null
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
 
 hg children at nullrev (should be 0 and 3)
   $ hg children
   changeset:   0:4df8521a7374
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     0
   
   changeset:   3:e2962852269d
   tag:         tip
   parent:      -1:000000000000
   user:        test
   date:        Thu Jan 01 00:00:03 1970 +0000
   summary:     3
   
   $ hg co 1
   2 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
 hg children at revision 1 (should be 2)
   $ hg children
   changeset:   2:8f5eea5023c2
   user:        test
   date:        Thu Jan 01 00:00:02 1970 +0000
   summary:     2
   
   $ hg co 2
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
 hg children at revision 2 (other head)
   $ hg children
 
   $ for i in null 0 1 2 3; do
   > echo "hg children -r $i"
   > hg children -r $i
   > done
   hg children -r null
   changeset:   0:4df8521a7374
   user:        test
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     0
   
   changeset:   3:e2962852269d
   tag:         tip
   parent:      -1:000000000000
   user:        test
   date:        Thu Jan 01 00:00:03 1970 +0000
   summary:     3
   
   hg children -r 0
   changeset:   1:708c093edef0
   user:        test
   date:        Thu Jan 01 00:00:01 1970 +0000
   summary:     1
   
   hg children -r 1
   changeset:   2:8f5eea5023c2
   user:        test
   date:        Thu Jan 01 00:00:02 1970 +0000
   summary:     2
   
   hg children -r 2
   hg children -r 3
 
 hg children -r 0 file0 (should be 2)
   $ hg children -r 0 file0
   changeset:   2:8f5eea5023c2
   user:        test
   date:        Thu Jan 01 00:00:02 1970 +0000
   summary:     2
   
 
 hg children -r 1 file0 (should be 2)
   $ hg children -r 1 file0
   changeset:   2:8f5eea5023c2
   user:        test
   date:        Thu Jan 01 00:00:02 1970 +0000
   summary:     2
   
 
   $ hg co 0
   1 files updated, 0 files merged, 1 files removed, 0 files unresolved
 
 hg children file0 at revision 0 (should be 2)
   $ hg children file0
   changeset:   2:8f5eea5023c2
   user:        test
   date:        Thu Jan 01 00:00:02 1970 +0000
   summary:     2
   
 
+should be compatible with templater (don't pass fctx to displayer)
+  $ hg children file0 -Tdefault
+  changeset:   2:8f5eea5023c2
+  user:        test
+  date:        Thu Jan 01 00:00:02 1970 +0000
+  summary:     2
+  
+
   $ cd ..