##// END OF EJS Templates
dirstate.status: assign members one by one instead of unpacking the tuple...
Siddharth Agarwal -
r21810:4b2ebd31 default
parent child Browse files
Show More
@@ -823,7 +823,18 b' class dirstate(object):'
823 uadd(fn)
823 uadd(fn)
824 continue
824 continue
825
825
826 state, mode, size, time = dmap[fn]
826 # This is equivalent to 'state, mode, size, time = dmap[fn]' but not
827 # written like that for performance reasons. dmap[fn] is not a
828 # Python tuple in compiled builds. The CPython UNPACK_SEQUENCE
829 # opcode has fast paths when the value to be unpacked is a tuple or
830 # a list, but falls back to creating a full-fledged iterator in
831 # general. That is much slower than simply accessing and storing the
832 # tuple members one by one.
833 t = dmap[fn]
834 state = t[0]
835 mode = t[1]
836 size = t[2]
837 time = t[3]
827
838
828 if not st and state in "nma":
839 if not st and state in "nma":
829 dadd(fn)
840 dadd(fn)
General Comments 0
You need to be logged in to leave comments. Login now