revlog: subclass the new `repository.iverifyproblem` Protocol class

This is the same transformation as 3a90a6fd710d did for dirstate, but the
CamelCase naming was already cleaned up here.

We shouldn't have to explicitly subclass, but I'm doing so to test the interplay
of regular attributes and the `attrs` class.  Also, PyCharm has a nifty feature
that puts a jump point in the gutter to navigate back and forth between the base
class and subclasses (and override functions and base class functions) when
there's an explicit subclassing.  Additionally, PyCharm will immediately flag
signature mismatches without a 40m pytype run.

hgext/sqlitestore.py

@@ -51,6 +51,10 import threading
 import typing
 import zlib
 
+from typing import (
+    Optional,
+)
+
 from mercurial.i18n import _
 from mercurial.node import (
     nullrev,
@@ -300,12 +304,11 class sqliterevisiondelta:
     linknode = attr.ib(default=None)
 
 
[e-mail](repository.iverifyproblem)
 @attr.s(frozen=True)
-class sqliteproblem:
-    warning = attr.ib(default=None)
-    error = attr.ib(default=None)
-    node = attr.ib(default=None)
+class sqliteproblem(repository.iverifyproblem):
+    warning = attr.ib(default=None, type=Optional[bytes])
+    error = attr.ib(default=None, type=Optional[bytes])
+    node = attr.ib(default=None, type=Optional[bytes])
 
 
 @interfaceutil.implementer(repository.ifilestorage)

mercurial/filelog.py

@@ -241,7 +241,7 class filelog: # (repository.ifilestora
         """
         return not storageutil.filedataequivalent(self, node, text)
 
-    def verifyintegrity(self, state) -> Iterable[revlog.revlogproblem]:
+    def verifyintegrity(self, state) -> Iterable[repository.iverifyproblem]:
         return self._revlog.verifyintegrity(state)
 
     def storageinfo(

mercurial/revlog.py

@@ -204,7 +204,7 class revlogrevisiondelta: # (repositor
 
 
 @attr.s(frozen=True)
-class revlogproblem:  # (repository.iverifyproblem)
+class revlogproblem(repository.iverifyproblem):
     warning = attr.ib(default=None, type=Optional[bytes])
     error = attr.ib(default=None, type=Optional[bytes])
     node = attr.ib(default=None, type=Optional[bytes])
@@ -4021,7 +4021,7 class revlog:
         else:
             rewrite.v2_censor(self, tr, censor_nodes, tombstone)
 
-    def verifyintegrity(self, state) -> Iterable[revlogproblem]:
+    def verifyintegrity(self, state) -> Iterable[repository.iverifyproblem]:
         """Verifies the integrity of the revlog.
 
         Yields ``revlogproblem`` instances describing problems that are

tests/simplestorerepo.py

@@ -13,6 +13,10
 
 import stat
 
+from typing import (
+    Optional,
+)
+
 from mercurial.i18n import _
 from mercurial.node import (
     bin,
@@ -82,12 +86,11 class simplestorerevisiondelta:
     linknode = attr.ib(default=None)
 
 
[e-mail](repository.iverifyproblem)
 @attr.s(frozen=True)
-class simplefilestoreproblem:
-    warning = attr.ib(default=None)
-    error = attr.ib(default=None)
-    node = attr.ib(default=None)
+class simplefilestoreproblem(repository.iverifyproblem):
+    warning = attr.ib(default=None, type=Optional[bytes])
+    error = attr.ib(default=None, type=Optional[bytes])
+    node = attr.ib(default=None, type=Optional[bytes])
 
 
 @interfaceutil.implementer(repository.ifilestorage)