largefiles: eliminate naked exceptions

hgext/largefiles/lfcommands.py

@@ -65,6 +65,7 b' def lfconvert(ui, src, dest, *pats, **op'
         ui.traceback()
         raise util.Abort(_('%s is not a repo') % dest)
 
+    success = False
     try:
         # Lock destination to prevent modification while it is converted to.
         # Don't need to lock src because we are just reading from its history
@@ -106,7 +107,7 b' def lfconvert(ui, src, dest, *pats, **op'
                     os.unlink(rdst.wjoin(f))
                 try:
                     os.removedirs(os.path.dirname(rdst.wjoin(f)))
-                except:
+                except OSError:
                     pass
 
         else:
@@ -116,11 +117,11 b' def lfconvert(ui, src, dest, *pats, **op'
                 _addchangeset(ui, rsrc, rdst, ctx, revmap)
 
             ui.progress(_('converting revisions'), None)
-    except:
-        # we failed, remove the new directory
-        shutil.rmtree(rdst.root)
-        raise
+        success = True
     finally:
+        if not success:
+            # we failed, remove the new directory
+            shutil.rmtree(rdst.root)
         dst_lock.release()
 
 def _addchangeset(ui, rsrc, rdst, ctx, revmap):

hgext/largefiles/lfutil.py

@@ -103,12 +103,7 b' def findoutgoing(repo, remote, force):'
 
 if os.name == 'nt':
     from mercurial import win32
-    try:
-        linkfn = win32.oslink
-    except:
-        linkfn = win32.os_link
-else:
-    linkfn = os.link
+    linkfn = win32.oslink
 
 def link(src, dest):
     try:

hgext/largefiles/reposetup.py

@@ -114,7 +114,7 b' def reposetup(ui, repo):'
                             return file in ctx.manifest()
                         ctx[file]
                         return True
-                    except:
+                    except KeyError:
                         return False
 
                 # create a copy of match that matches standins instead of