filterpyflakes: move self-test into test file

This will avoid a false positive on an upcoming check-code rule.

Differential Revision: https://phab.mercurial-scm.org/D18

tests/filterpyflakes.py

@@ -1,41 +1,37 b''
 #!/usr/bin/env python
 
 # Filter output by pyflakes to control which warnings we check
 
 from __future__ import absolute_import, print_function
 
 import re
 import sys
 
 lines = []
 for line in sys.stdin:
     # We blacklist tests that are too noisy for us
     pats = [
         r"undefined name 'WindowsError'",
         r"redefinition of unused '[^']+' from line",
         # for cffi, allow re-exports from pure.*
         r"cffi/[^:]*:.*\bimport \*' used",
         r"cffi/[^:]*:.*\*' imported but unused",
     ]
 
     keep = True
     for pat in pats:
         if re.search(pat, line):
             keep = False
             break # pattern matches
     if keep:
         fn = line.split(':', 1)[0]
         f = open(fn)
         data = f.read()
         f.close()
         if 'no-' 'check-code' in data:
             continue
         lines.append(line)
 
 for line in lines:
     sys.stdout.write(line)
 print()
-
-# self test of "undefined name" detection
-if False:
-    print(undefinedname)

tests/test-check-pyflakes.t

@@ -1,15 +1,21 b''
 #require test-repo pyflakes hg10
 
   $ . "$TESTDIR/helpers-testrepo.sh"
   $ cd "`dirname "$TESTDIR"`"
 
 run pyflakes on all tracked files ending in .py or without a file ending
 (skipping binary file random-seed)
 
+  $ cat > test.py <<EOF
+  > print(undefinedname)
+  > EOF
+  $ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"
+  test.py:1: undefined name 'undefinedname'
+  
+
   $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
   > -X hgext/fsmonitor/pywatchman \
   > -X mercurial/pycompat.py -X contrib/python-zstandard \
   > 2>/dev/null \
   > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
-  tests/filterpyflakes.py:41: undefined name 'undefinedname'