verify: allow suppressing warnings about extra files

The verifier issues warnings when the set of files in .hg/store
doesn't align with the set of files that are advertised via
repo.file(f).files() for all files seen in ctx.files() changelog
traversal.

This logic is reasonable for a default implementation. But some
stores may have extra files whose presence is harmless. Or those
stores may not have the same transaction rollback semantics that
unlink files as other stores.

This commit adds support for disabling the warning for orphaned
files.

The simple store extension has been taught to set this flag.

Differential Revision: https://phab.mercurial-scm.org/D3097

mercurial/verify.py

@@ -52,6 +52,7 b' class verifier(object):'
         self.fncachewarned = False
         # developer config: verify.skipflags
         self.skipflags = repo.ui.configint('verify', 'skipflags')
+        self.warnorphanstorefiles = True
 
     def warn(self, msg):
         self.ui.warn(msg + "\n")
@@ -294,6 +295,7 b' class verifier(object):'
 
         if not dir and subdirnodes:
             ui.progress(_('checking'), None)
+            if self.warnorphanstorefiles:
             for f in sorted(storefiles):
                 self.warn(_("warning: orphan data file '%s'") % f)
 
@@ -369,7 +371,9 b' class verifier(object):'
                 try:
                     storefiles.remove(ff)
                 except KeyError:
-                    self.warn(_(" warning: revlog '%s' not in fncache!") % ff)
+                    if self.warnorphanstorefiles:
+                        self.warn(_(" warning: revlog '%s' not in fncache!") %
+                                  ff)
                     self.fncachewarned = True
 
             self.checklog(fl, f, lr)
@@ -481,6 +485,7 b' class verifier(object):'
                              short(node), f)
         ui.progress(_('checking'), None)
 
+        if self.warnorphanstorefiles:
         for f in sorted(storefiles):
             self.warn(_("warning: orphan data file '%s'") % f)
 

tests/simplestorerepo.py

@@ -35,6 +35,7 b' from mercurial import ('
     pycompat,
     revlog,
     store,
+    verify,
 )
 
 # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
@@ -656,9 +657,17 b' def makestore(orig, requirements, path, '
 
     return simplestore(path, vfstype)
 
+def verifierinit(orig, self, *args, **kwargs):
+    orig(self, *args, **kwargs)
+
+    # We don't care that files in the store don't align with what is
+    # advertised. So suppress these warnings.
+    self.warnorphanstorefiles = False
+
 def extsetup(ui):
     localrepo.featuresetupfuncs.add(featuresetup)
 
     extensions.wrapfunction(localrepo, 'newreporequirements',
                             newreporequirements)
     extensions.wrapfunction(store, 'store', makestore)
+    extensions.wrapfunction(verify.verifier, '__init__', verifierinit)